Skip to content

Comments

New API version 2019-07-01 for ANF#7020

Merged
jhendrixMSFT merged 7 commits intoAzure:masterfrom
leonardbf:master
Sep 6, 2019
Merged

New API version 2019-07-01 for ANF#7020
jhendrixMSFT merged 7 commits intoAzure:masterfrom
leonardbf:master

Conversation

@leonardbf
Copy link
Contributor

@leonardbf leonardbf commented Aug 22, 2019

First commit contains previous 2019-06-01 as 2019-07-01.
Then updated with new API changes.
Main changes

  • volume property renaming NFSv4 to NFSv4.1
  • snapshot property renaming creation_date to created.

Replaces #7012

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@leonardbf leonardbf mentioned this pull request Aug 22, 2019
Closed
5 tasks
@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 22, 2019

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 22, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 34d7445, Iteration 2)

In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.

@AutorestCI AutorestCI mentioned this pull request Aug 22, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 22, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7092

@AutorestCI AutorestCI mentioned this pull request Aug 22, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 22, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5711

This was referenced Aug 22, 2019
Closed
Closed
Closed
Closed
Closed
@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 26, 2019
@paulomarquesc
Copy link

paulomarquesc commented Sep 5, 2019

Hi @anthony-c-martin , can you please review this PR?

KrisBash
KrisBash approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 6, 2019
@yungezz yungezz closed this Sep 6, 2019
@yungezz yungezz reopened this Sep 6, 2019
This was referenced Sep 6, 2019
Merged
Merged
@jhendrixMSFT jhendrixMSFT merged commit c09e541 into Azure:master Sep 6, 2019
@leonardbf leonardbf mentioned this pull request Sep 23, 2019
Merged
@leonardbf leonardbf mentioned this pull request Oct 29, 2019
Merged
5 tasks
@leonardbf leonardbf mentioned this pull request Dec 13, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulomarquesc paulomarquesc paulomarquesc left review comments

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

+1 more reviewer

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jhendrixMSFT jhendrixMSFT

@anthony-c-martin anthony-c-martin

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@leonardbf @azuresdkci @AutorestCI @paulomarquesc @KrisBash @jhendrixMSFT @yungezz @anthony-c-martin