some fixes for frontdoor readme by zikalino · Pull Request #7424 · Azure/azure-rest-api-specs

zikalino · 2019-10-08T05:40:28Z

No description provided.

openapi-sdkautomation · 2019-10-08T05:40:31Z

In Testing, Please Ignore

[Logs] (Generated from 3a7dbc7, Iteration 10)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.FrontDoor [Logs] [Instructions]
- Microsoft.Azure.Management.FrontDoor.1.0.0.nupkg
- Microsoft.Azure.Management.FrontDoor.1.0.0.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-frontdoor [Logs] [Instructions] [Generation PR]
- azure-mgmt-frontdoor-0.1.0.zip
- azure_mgmt_frontdoor-0.1.0-py2.py3-none-any.whl

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

frontdoor/mgmt/2019-04-01 [Logs] [Instructions] [Generation PR]
- frontdoor.mgmt.2019-04-01.zip
frontdoor/mgmt/2019-05-01 [Logs] [Instructions] [Generation PR]
- frontdoor.mgmt.2019-05-01.zip
preview/frontdoor/mgmt/2018-08-01-preview [Logs] [Instructions] [Generation PR]
- preview.frontdoor.mgmt.2018-08-01-preview.zip

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-frontdoor [Logs] [Instructions]
- azure-arm-frontdoor-3.1.0.tgz

AutorestCI · 2019-10-08T05:41:18Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#7714

AutorestCI · 2019-10-08T05:43:20Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkci · 2019-10-08T06:01:49Z

Can one of the admins verify this patch?

yungezz · 2019-10-08T06:12:55Z

specification/frontdoor/resource-manager/readme.md

 description: FrontDoor Client
 openapi-type: arm
-tag: package-2019-10
+tag: package-2019-11


is package-2019-10 released before?

no, package-2019-10 and package-2019-11 were for some reason both created just several days ago.
it anything was released using one of these tags, package would be invalid.

yungezz · 2019-10-09T02:17:13Z

...cation/frontdoor/resource-manager/Microsoft.Network/stable/2019-11-01/networkexperiment.json

            ],
            "x-ms-enum": {
-              "name": "aggregationInterval",
+              "name": "latencyScoreboardAggregationInterval",


this is a potential breaking change, is this a swagger bug fixing to align with existing service behavior?

this should say "latencyScorecardAggregationInterval"

@minechosoft renamed to Scorecard

@yungezz changing name in x-ms-enum only results in SDK changes. anyway, we had to change this name, as there were two different enums with the same name, and that was causing autorest to fail. Any other changes I made were checked by @minechosoft and service is going to be aligned.

yungezz · 2019-10-09T02:17:50Z

...cation/frontdoor/resource-manager/Microsoft.Network/stable/2019-11-01/networkexperiment.json

-        "disabling",
-        "disabled",
-        "deleting"
+        "Creating",


again, breaking change

discussed with service team, they will make sure RP is in sync (networkexperiment was not release yet)

yes. it's not breaking-- we will make sure to have these changes reflected in our service.

minechosoft · 2019-10-09T02:41:52Z

...cation/frontdoor/resource-manager/Microsoft.Network/stable/2019-11-01/networkexperiment.json

        "resourceState": {
          "description": "Resource status.",
-          "$ref": "#/definitions/ResourceState"
+          "$ref": "#/definitions/NetworkExperimentationResourceState"


"NetworkExperimentResourceState"

minechosoft · 2019-10-09T04:42:45Z

...cation/frontdoor/resource-manager/Microsoft.Network/stable/2019-11-01/networkexperiment.json

        "resourceState": {
          "description": "Resource status.",
-          "$ref": "#/definitions/ResourceState"
+          "$ref": "#/definitions/NetworkExperimentationResourceState"


"NetworkExperimentResourceState"

updated frontdoor readme

75e3711

azuresdkci assigned yungezz Oct 8, 2019

azuresdkci requested a review from yungezz October 8, 2019 05:42

yungezz reviewed Oct 8, 2019

View reviewed changes

Zim Kalinowski added 8 commits October 8, 2019 22:01

fixed invalid values

a933aa3

fixing examples etc

790a72e

further updates

d150a7b

fixed Enabled / Disabled

7e50ace

removed readme.cli checked in by mistake

07eb2cb

renamed ResourceState -> NetworkExperimenationResourceState

568318d

renamed aggregation intervals

e5fa469

Updated timeseriesType

729f342

openapi-sdkautomation bot mentioned this pull request Oct 9, 2019

[AutoPR Microsoft.Azure.Management.FrontDoor] some fixes for frontdoor readme test-repo-billy/azure-sdk-for-net#289

Closed

yungezz reviewed Oct 9, 2019

View reviewed changes

minechosoft reviewed Oct 9, 2019

View reviewed changes

Zim Kalinowski added 2 commits October 9, 2019 10:54

scorecard -> scoreboard

9630e7a

network experiment resource state

3a7dbc7

minechosoft reviewed Oct 9, 2019

View reviewed changes

yungezz approved these changes Oct 9, 2019

View reviewed changes

yungezz merged commit dac2b80 into master Oct 9, 2019

AutorestCI mentioned this pull request Oct 9, 2019

[AutoPR frontdoor/resource-manager] some fixes for frontdoor readme Azure/azure-sdk-for-python#7714

Merged

JackTn deleted the updated-frontdoor-readme branch August 9, 2021 10:17

Conversation

zikalino commented Oct 8, 2019

Uh oh!

openapi-sdkautomation bot commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 3a7dbc7, Iteration 10)

Uh oh!

AutorestCI commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Oct 8, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-sdkautomation bot commented Oct 8, 2019 •

edited

Loading

AutorestCI commented Oct 8, 2019 •

edited

Loading

AutorestCI commented Oct 8, 2019 •

edited

Loading