-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Billing RP spec changes for listInvoiceSectionsWithCreateSubscription… #6964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In Testing, Please Ignore[Logs] (Generated from fa4f267, Iteration 9)
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json
Show resolved
Hide resolved
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
|
Can one of the admins verify this patch? |
...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json
Show resolved
Hide resolved
|
@anthony-c-martin Please review this PR and provide ARM Sign off if it looks good. |
mmyyrroonn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This PR contains BreakingChanges. It's preview version.
|
@KrisBash @asarkar84 Hello. Do you discuss about this PR offline? @asarkar84 Do you know how to change this PR? |
|
@myronfanqiu I have not discussed the changes with @KrisBash offline. |
KrisBash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KrisBash I am not able to see the comments from you in this PR. Please add them.
@asarkar84 I'm not sure what the issue is - I see my comments directly above this and in the PR code diff.
...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json
Show resolved
Hide resolved
...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json
Show resolved
Hide resolved
Incorporated review comments
|
@KrisBash I have incorporated the review comments. Kindly take a look. |
|
@KrisBash Truly sorry! I just made a mistake that not wait for your confirmation. Could you please check whether the author has solved your comments. @asarkar84 Hello. I'm sorry I just merged this PR. Just as a reminder, we may need further changes. Truly sorry for my mistake. |
…Permission API
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.