Skip to content

Conversation

@asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented Aug 15, 2019

…Permission API

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@asarkar84 asarkar84 requested a review from wilcobmsft as a code owner August 15, 2019 00:12
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 15, 2019

In Testing, Please Ignore

[Logs] (Generated from fa4f267, Iteration 9)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed billing/resource-manager/v2017_02_27_preview [Logs] [Generation PR]
  • Failed billing/resource-manager/v2017_04_24_preview [Logs]
  • Failed billing/resource-manager/v2018_03_01_preview [Logs]
  • Failed billing/resource-manager/v2018_11_01_preview [Logs]
  • Failed billing/resource-manager/v2019_10_01_preview [Logs]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6867

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@mmyyrroonn mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 15, 2019
@asarkar84
Copy link
Contributor Author

@anthony-c-martin Please review this PR and provide ARM Sign off if it looks good.

Copy link
Contributor

@mmyyrroonn mmyyrroonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR contains BreakingChanges. It's preview version.

@mmyyrroonn
Copy link
Contributor

@KrisBash @asarkar84 Hello. Do you discuss about this PR offline? @asarkar84 Do you know how to change this PR?

@asarkar84
Copy link
Contributor Author

@myronfanqiu I have not discussed the changes with @KrisBash offline.
@KrisBash I am not able to see the comments from you in this PR. Please add them.

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrisBash I am not able to see the comments from you in this PR. Please add them.

@asarkar84 I'm not sure what the issue is - I see my comments directly above this and in the PR code diff.

Incorporated review comments
@asarkar84
Copy link
Contributor Author

@KrisBash I have incorporated the review comments. Kindly take a look.

@mmyyrroonn
Copy link
Contributor

@KrisBash Truly sorry! I just made a mistake that not wait for your confirmation. Could you please check whether the author has solved your comments. @asarkar84 Hello. I'm sorry I just merged this PR. Just as a reminder, we may need further changes. Truly sorry for my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants