Skip to content

Conversation

@bobtista
Copy link

@bobtista bobtista commented Oct 31, 2025

Changes

  • 52 files renamed from .H/.CPP.h/.cpp
  • 192 files updated with corrected #include statements
  • 244 total files changed (320 insertions, 320 deletions)
  • Zero functional changes - purely cosmetic refactoring

Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest do one more string search for .H and .CPP across all files.

@xezon xezon added the Refactor Edits the code with insignificant behavior changes, is never user facing label Oct 31, 2025
@bobtista bobtista force-pushed the bobtista/lowercase-file-extensions branch 2 times, most recently from 93d27f7 to dba750c Compare October 31, 2025 14:48
@bobtista
Copy link
Author

I suggest do one more string search for .H and .CPP across all files.

Done :)

Check for uppercase extension files

find . -name ".H" -o -name ".CPP" | grep -v build | wc -l

Check for uppercase includes

grep -r '#include..(H|CPP)"' --include=".{cpp,h}" --exclude-dir=build . | wc -l

Check CMakeLists.txt

grep -r '.(H|CPP)"' --include="CMakeLists.txt" --exclude-dir=build . | wc -l

- Update CMakeLists.txt files (WWLib, pluglib)
- Fix Jsupport.cpp encoding corruption from sed
- Fix disabled/conditional includes (WWLib, WW3D tools, W3DView)
- Fix all remaining uppercase .H/.CPP references in source files
@bobtista bobtista force-pushed the bobtista/lowercase-file-extensions branch from dba750c to 8350f2c Compare October 31, 2025 14:52
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code still contains .H and .CPP in includes and comments.

@bobtista
Copy link
Author

bobtista commented Oct 31, 2025

Code still contains .H and .CPP in includes and comments.

I could only find .H and .CPP in historical comments eg C O N F I D E N T I A L --- W E S T W O O D S T U D I O S ones.

I just added a commit to update these too, but I don't see anything in includes, only in comments - can you show me an example?

@bobtista bobtista force-pushed the bobtista/lowercase-file-extensions branch from 2720438 to 72ee2e1 Compare October 31, 2025 18:25
@xezon
Copy link

xezon commented Oct 31, 2025

I used Visual Studio Code and searched whole Project.

@bobtista
Copy link
Author

I used Visual Studio Code and searched whole Project.

I search the whole project for ".CPP" with case sensitivity on, and I see no results. Is it possible that your local environment isn't synced to the latest commit? e114e0c

@xezon
Copy link

xezon commented Oct 31, 2025

I grabbed latest code and can confirm that there is no left over .H and .CPP

@xezon xezon added this to the Code foundation build up milestone Oct 31, 2025
@xezon xezon changed the title refactor: Normalize file extensions to lowercase across codebase refactor: Normalize all file extensions to lowercase Oct 31, 2025
@xezon xezon merged commit 24f8da9 into TheSuperHackers:main Oct 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants