-
Notifications
You must be signed in to change notification settings - Fork 117
refactor: Normalize all file extensions to lowercase #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Normalize all file extensions to lowercase #1765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest do one more string search for .H and .CPP across all files.
93d27f7 to
dba750c
Compare
Done :) Check for uppercase extension filesfind . -name ".H" -o -name ".CPP" | grep -v build | wc -l Check for uppercase includesgrep -r '#include..(H|CPP)"' --include=".{cpp,h}" --exclude-dir=build . | wc -l Check CMakeLists.txtgrep -r '.(H|CPP)"' --include="CMakeLists.txt" --exclude-dir=build . | wc -l |
- Update CMakeLists.txt files (WWLib, pluglib) - Fix Jsupport.cpp encoding corruption from sed - Fix disabled/conditional includes (WWLib, WW3D tools, W3DView) - Fix all remaining uppercase .H/.CPP references in source files
dba750c to
8350f2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code still contains .H and .CPP in includes and comments.
I could only find .H and .CPP in historical comments eg C O N F I D E N T I A L --- W E S T W O O D S T U D I O S ones. I just added a commit to update these too, but I don't see anything in includes, only in comments - can you show me an example? |
2720438 to
72ee2e1
Compare
|
I used Visual Studio Code and searched whole Project. |
I search the whole project for ".CPP" with case sensitivity on, and I see no results. Is it possible that your local environment isn't synced to the latest commit? e114e0c |
|
I grabbed latest code and can confirm that there is no left over .H and .CPP |
Changes
.H/.CPP→.h/.cpp#includestatements