--wip-- [skip ci] #638
Closed
--wip-- [skip ci] #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
1afd9de to
b09fec0
Compare
jamesmengo
force-pushed
the
jm/doc_param
branch
from
790d036 to
246e6df
Compare
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
b09fec0 to
450083b
Compare
jamesmengo
force-pushed
the
jm/doc_param
branch
from
246e6df to
d3eae37
Compare
2 tasks
|
@jamesmengo can we close this? |
- Added `paramNode` to the grammar for LiquidDoc, allowing for parameter definitions in doc tags. - Updated the parsing logic to recognize and handle `@param` syntax correctly. - Modified CST tests to validate the new structure, ensuring proper identification of `LiquidDocParamNode` and associated text nodes. - Refactored existing tests to align with the new parsing rules and improve accuracy.
- Updated the `toLiquidDocAST` function to include handling for `@param` syntax and fallback text node
jamesmengo
force-pushed
the
jm/doc_param
branch
from
d3eae37 to
64f7dd8
Compare
This was referenced Dec 5, 2024
This was referenced Jan 7, 2025
This was referenced Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
What's next? Any followup issues?
What did you learn?
Before you deploy
changesetallChecksarray insrc/checks/index.tsyarn buildand committed the updated configuration filestheme-app-extension.ymlconfigchangesetchangeset