Add parsing + prettier support for @param in {% doc %} tags #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jamesmengo
force-pushed
the
jm/implement_fallbackNode
branch
from
4d4c72d to
92a1d96
Compare
jamesmengo
force-pushed
the
jm/doc_param
branch
2 times, most recently
from
64f7dd8 to
944ecb4
Compare
jamesmengo
force-pushed
the
jm/implement_fallbackNode
branch
from
92a1d96 to
10ded69
Compare
This was referenced Dec 4, 2024
jamesmengo
changed the title
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
330b509 to
59c43dc
Compare
jamesmengo
force-pushed
the
jm/implement_fallbackNode
branch
from
10ded69 to
79f4c94
Compare
8 tasks
jamesmengo
commented
Dec 5, 2024
| @@ -402,7 +402,8 @@ function findCurrentNode( | |||
| case NodeTypes.TextNode: | |||
| case NodeTypes.LiquidLiteral: | |||
| case NodeTypes.String: | |||
| case NodeTypes.Number: { | |||
| case NodeTypes.Number: | |||
| case NodeTypes.LiquidDocParamNode: { | |||
There was a problem hiding this comment.
This exists to appease CI for the moment - I foresee us revisiting this once we are implementing completions
jamesmengo
changed the title
jamesmengo
commented
Dec 5, 2024
| @@ -1103,7 +1109,7 @@ export function cstToAst( | |||
| } | |||
|
|
|||
| function buildAst( | |||
| cst: LiquidHtmlCST | LiquidCST | ConcreteAttributeNode[], | |||
| cst: LiquidHtmlCST | LiquidCST | LiquidDocCST | ConcreteAttributeNode[], | |||
There was a problem hiding this comment.
Should I just be adding this to LiquidHtmlCST ? My plan is to allow LiquidDocCST to evolve over time. I wanted to keep them separate as much as possible since LiquidDoc is kind of its own thing
cc: @charlespwd
jamesmengo
force-pushed
the
jm/implement_fallbackNode
branch
from
1a1108a to
68227c4
Compare
Implement fallbackNode for LiquidDoc Enhance Liquid HTML Parser: Introduce paramNode and update CST tests - Added `paramNode` to the grammar for LiquidDoc, allowing for parameter definitions in doc tags. - Updated the parsing logic to recognize and handle `@param` syntax correctly. - Modified CST tests to validate the new structure, ensuring proper identification of `LiquidDocParamNode` and associated text nodes. - Refactored existing tests to align with the new parsing rules and improve accuracy. Introduce LiquidDocCST and LiquidDocConcrete Add liquidDocParam handling to stage2 AST - Updated the `toLiquidDocAST` function to include handling for `@param` syntax and fallback text node Prettier - Add CSS Handling Enhance LiquidCompletionParams: Add handling for LiquidDocParamNode in LiquidCompletionParams Add LiquidCST to union of LiquidHTMLCST types Add LiquidDocParamNode case to print function Add basic prettier support for doc tag
jamesmengo
force-pushed
the
jm/implement_fallbackNode
branch
from
68227c4 to
e7ed99d
Compare
jamesmengo
changed the title
jamesmengo
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
What's next? Any followup issues?
What did you learn?
Before you deploy
changesetallChecksarray insrc/checks/index.tsyarn buildand committed the updated configuration filestheme-app-extension.ymlconfigchangesetchangeset