Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'doc' to TAGS_WITHOUT_MARKUP #637

Closed
wants to merge 5 commits into from
Closed

Add 'doc' to TAGS_WITHOUT_MARKUP #637

wants to merge 5 commits into from
+116 −1

Conversation

jamesmengo
Copy link
Contributor

What are you adding in this PR?

What's next? Any followup issues?

What did you learn?

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

@jamesmengo
Add liquidDoc tag to liquidHTMLParser
1e24ef0 
Add stage-2 ast tests for doc tags
@jamesmengo
Add liquidDocBody to liquidHTMLParser
84b7136
@jamesmengo
Refactor: create new grammar for doc tags
a6b207d 
LiquidDoc is essentially a new language that we are adding.
Creating a new grammar allows us to directly parse and test the contents of the doc tag.
This also allows us to avoid the complexity of including liquid support from within the doc tag grammar.
@jamesmengo
Theme Check - Update theme-check-common to include doc tag
e3abda9
@jamesmengo
Add 'doc' to TAGS_WITHOUT_MARKUP
03aeddc 
reason: doc tag cannot have markup, so we strip it if present in stage 2.
@jamesmengo Graphite App
Copy link
Contributor Author

jamesmengo commented Dec 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 3, 2024
Open
Merged
@jamesmengo jamesmengo closed this Dec 3, 2024
@jamesmengo jamesmengo deleted the jm/doc_tag_without_markup branch December 3, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesmengo