Add basic prettier support for doc tag #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
charlespwd
reviewed
Dec 5, 2024
| // One of the benefits of leaving it here is that we can use the indentation and other logic from the raw markup. | ||
| // The benefit of doing it in LiquidRawTag is that we can keep the logic for doc separate | ||
| // I still want to understand how embeddings would work in this scenario. Maybe that's a complete different approach that we could take. | ||
| return [indent([hardline, body]), hardline]; |
There was a problem hiding this comment.
LiquidRawTag exists mostly because we want to paste the body back as it was ("raw"). So body here is actually just a string and not a "recursive call to print". This is why the asdf thing at the bottom never gets called. You need to do some kind of path.call(p => print(p), 'children') to make it recursive.
jamesmengo
force-pushed
the
jm/basic_prettier_support
branch
3 times, most recently
from
7b277c1 to
d4803fa
Compare
Add doc param tag
- Added `paramNode` to the grammar for LiquidDoc, allowing for parameter definitions in doc tags. - Updated the parsing logic to recognize and handle `@param` syntax correctly. - Modified CST tests to validate the new structure, ensuring proper identification of `LiquidDocParamNode` and associated text nodes. - Refactored existing tests to align with the new parsing rules and improve accuracy.
- Updated the `toLiquidDocAST` function to include handling for `@param` syntax and fallback text node
…n LiquidCompletionParams
jamesmengo
force-pushed
the
jm/implement_fallbackNode
branch
from
1a1108a to
68227c4
Compare
jamesmengo
force-pushed
the
jm/basic_prettier_support
branch
from
d4803fa to
0f17fef
Compare
jamesmengo
force-pushed
the
jm/implement_fallbackNode
branch
from
68227c4 to
e7ed99d
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
What's next? Any followup issues?
What did you learn?
Before you deploy
changesetallChecksarray insrc/checks/index.tsyarn buildand committed the updated configuration filestheme-app-extension.ymlconfigchangesetchangeset