-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### WHY are these changes introduced? Rollup and Babel are blocking our migration to minimum NodeJS version 16. This PR updated all Rollup and Babel dependencies. These NPM package upgrades are not compatible with NodeJS 14.17 (main branch version). This change unblocks a larger change to our NodeJS versions. ### WHAT is this pull request doing? - [x] Moves duplicate dependencies to root - [x] Upgrades all rollup and babel dependencies - [x] Fixes any required breaking changes or warnings - [x] Compared diff of previous packages and new ones and it doesn't have a regression ### How to 🎩 1. Run a build on `main` save the built files on desktop 1. Run a build on this `bump-build-deps` save the built files on desktop 1. Run a diff over the built files 1. Make sure no regressions 1. CI, tests should pass and website should render all pages. **@alex-page's output from Diff:** [diff.zip](https://github.com/Shopify/polaris/files/10531068/diff.zip) ``` diff -bur polaris-tokens/dist-main polaris-tokens/dist-v11 > icons.diff diff -bur polaris-tokens/dist-main polaris-tokens/dist-v11 > tokens.diff diff -bur polaris-migrator/dist-main polaris-migrator/dist-v11 > migrator.diff diff -bur polaris-react/build-main polaris-react/build-v11 > react.diff ``` ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
- Loading branch information
Showing
8 changed files
with
296 additions
and
166 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.