Make metafields optional within the ProductProvider. Fixes #1127 #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
commented
May 5, 2022
| /** A [MetafieldConnection](https://shopify.dev/api/storefront/reference/common-objects/metafieldconnection). */ | ||
| metafields?: PartialDeep<MetafieldConnection> | ||
| ) { | ||
| metafields?.edges?.[0]?.node; |
Contributor
Author
There was a problem hiding this comment.
I'm unsure what this was doing
Contributor
There was a problem hiding this comment.
Huh weird, I seem to have accidentally added it in a previous PR. https://github.com/Shopify/hydrogen/pull/959/files#diff-4c6b39cf631dbcd985b50139a085365a972de3824078975657f69500363426c8
blittle
commented
May 5, 2022
| const initialVariant = flattenConnection(product.variants)[0]; | ||
|
|
||
| const productMetafields = useParsedMetafields(product.metafields); | ||
| const productMetafields = useParsedMetafields(product.metafields || {}); |
Contributor
Author
There was a problem hiding this comment.
Because the default product details page shows metafields, maybe we do want it to error?
frehner
approved these changes
May 5, 2022
| /** A [MetafieldConnection](https://shopify.dev/api/storefront/reference/common-objects/metafieldconnection). */ | ||
| metafields?: PartialDeep<MetafieldConnection> | ||
| ) { | ||
| metafields?.edges?.[0]?.node; |
Contributor
There was a problem hiding this comment.
Huh weird, I seem to have accidentally added it in a previous PR. https://github.com/Shopify/hydrogen/pull/959/files#diff-4c6b39cf631dbcd985b50139a085365a972de3824078975657f69500363426c8
blittle
added a commit
that referenced
this pull request
May 9, 2022
* v1.x-2022-07: Fix stale product options (#1210) Upgrade body-parser in hydrogen package (#1232) Add new options to Money and useMoney (#1215) fix links (#1229) Update turbo and instructions for developing `dev` (#1225) Heck - deploy all branches to Oxygen add context for initialvariantid (#1217) Build chunks are inside assets folder (#1211) Upgraded to SFAPI 2022-07 (#1214) [ci] release v1.x-2022-07 (#1205) Make this a patch instead of minor add references to video in file_reference block (#1197) Laying the foundation for building components in isolation (#1188) Make metafields optional within the ProductProvider. Fixes #1127 (#1209) Add README to /templates directory (#1163) fix perf tracking and make it optional from developer's end (#1096) docs fixes (#1204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1127