Skip to content

Make metafields optional within the ProductProvider. Fixes #1127 #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

Make metafields optional within the ProductProvider. Fixes #1127 #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twelve-moles-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/hydrogen': patch
---

Make metafields optional within the ProductProvider. Fixes #1127
2 changes: 1 addition & 1 deletion packages/hydrogen/src/components/ProductProvider/ProductProvider.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function ProductProvider({
data: product,
initialVariantId,
}: ProductProviderProps) {
const metafields = useParsedMetafields(product.metafields);
const metafields = useParsedMetafields(product.metafields || {});

// @ts-expect-error The types here are broken on main, need to come back and fix them sometime
const providerValue = useMemo<ProductContextType>(() => {
Expand Down
1 change: 0 additions & 1 deletion packages/hydrogen/src/hooks/useParsedMetafields/useParsedMetafields.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export function useParsedMetafields(
/** A [MetafieldConnection](https://shopify.dev/api/storefront/reference/common-objects/metafieldconnection). */
metafields?: PartialDeep<MetafieldConnection>
) {
metafields?.edges?.[0]?.node;
Copy link
Contributor Author

@blittle blittle May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure what this was doing

Copy link
Contributor

@frehner frehner May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh weird, I seem to have accidentally added it in a previous PR. https://github.com/Shopify/hydrogen/pull/959/files#diff-4c6b39cf631dbcd985b50139a085365a972de3824078975657f69500363426c8

return useMemo(() => {
if (!metafields) {
throw new Error(`'useParsedMetafields' needs metafields`);
Expand Down
2 changes: 1 addition & 1 deletion templates/template-hydrogen-default/src/components/ProductDetails.client.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function ProductPrices() {
export default function ProductDetails({product}) {
const initialVariant = flattenConnection(product.variants)[0];

const productMetafields = useParsedMetafields(product.metafields);
const productMetafields = useParsedMetafields(product.metafields || {});
Copy link
Contributor Author

@blittle blittle May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the default product details page shows metafields, maybe we do want it to error?

const sizeChartMetafield = productMetafields.find(
(metafield) =>
metafield.namespace === 'my_fields' && metafield.key === 'size_chart',
Expand Down