Skip to content

Conversation

@arlyxiao
Copy link
Contributor

@arlyxiao arlyxiao commented May 9, 2022

Description

Continue from the this commit
Shopify/hydrogen#1162

Upgrade body-parser in hydrogen package only.

Additional context

Tested steps:

  1. Go to root folder.
  2. Do fresh installation by these commands: git checkout . && rm -rf node_modules && yarn
  3. Start by yarn dev
  4. Run yarn dev in examples/css-modules and verify.
  5. Run yarn dev in templates/template-hydrogen-default and verify.

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

@arlyxiao
Copy link
Contributor Author

arlyxiao commented May 9, 2022

@blittle

I did check in this weekend again. I forgot the framework in the last time.
Take a look at my tested steps. It should be fine.

btw: The latest of @types/body-parser is still ^1.19.2.

@blittle blittle merged commit d3956d6 into Shopify:v1.x-2022-07 May 9, 2022
blittle added a commit that referenced this pull request May 9, 2022
* v1.x-2022-07:
  Fix stale product options (#1210)
  Upgrade body-parser in hydrogen package (#1232)
  Add new options to Money and useMoney (#1215)
  fix links (#1229)
  Update turbo and instructions for developing `dev` (#1225)
  Heck - deploy all branches to Oxygen
  add context for initialvariantid (#1217)
  Build chunks are inside assets folder (#1211)
  Upgraded to SFAPI 2022-07 (#1214)
  [ci] release v1.x-2022-07 (#1205)
  Make this a patch instead of minor
  add references to video in file_reference block (#1197)
  Laying the foundation for building components in isolation (#1188)
  Make metafields optional within the ProductProvider. Fixes #1127 (#1209)
  Add README to /templates directory (#1163)
  fix perf tracking and make it optional from developer's end (#1096)
  docs fixes (#1204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants