Skip to content

Conversation

@mcvinci
Copy link
Contributor

@mcvinci mcvinci commented May 6, 2022

This PR:

Tophatted

Screen Shot 2022-05-05 at 11 13 53 PM

@mcvinci mcvinci self-assigned this May 6, 2022
@mcvinci mcvinci requested a review from frehner May 6, 2022 06:01
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@mcvinci
Copy link
Contributor Author

mcvinci commented May 6, 2022

@frehner I've made an attempt to capture the logic you referenced in this issue. Would you mind taking a look and confirming that what we're saying here is accurate? 🙏

Also, do we have any guidance that we can share at this point in terms of how to unset initialVariantId? I'd like to capture this in the reference topic as well!

@frehner
Copy link
Contributor

frehner commented May 6, 2022

Would you mind taking a look and confirming that what we're saying here is accurate? 🙏

That was the intention, yes, so I think you're good. However, @cartogram was the one that actually did the work on this, so he gets all the credit.

Also, do we have any guidance that we can share at this point in terms of Shopify/hydrogen#729 initialVariantId? I'd like to capture this in the reference topic as well!

Not that I'm aware of at the moment.

@mcvinci mcvinci merged commit f9ea839 into v1.x-2022-07 May 6, 2022
@mcvinci mcvinci deleted the initialvariantid-context branch May 6, 2022 16:05
blittle added a commit that referenced this pull request May 9, 2022
* v1.x-2022-07:
  Fix stale product options (#1210)
  Upgrade body-parser in hydrogen package (#1232)
  Add new options to Money and useMoney (#1215)
  fix links (#1229)
  Update turbo and instructions for developing `dev` (#1225)
  Heck - deploy all branches to Oxygen
  add context for initialvariantid (#1217)
  Build chunks are inside assets folder (#1211)
  Upgraded to SFAPI 2022-07 (#1214)
  [ci] release v1.x-2022-07 (#1205)
  Make this a patch instead of minor
  add references to video in file_reference block (#1197)
  Laying the foundation for building components in isolation (#1188)
  Make metafields optional within the ProductProvider. Fixes #1127 (#1209)
  Add README to /templates directory (#1163)
  fix perf tracking and make it optional from developer's end (#1096)
  docs fixes (#1204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants