Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abap-deploy-config): fix for local pkg verification #2289

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

cianmSAP
Copy link
Contributor

#2128

Convert packages to upper case for verifying when it is a local package

Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: 1e60fe1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/abap-deploy-config-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Tests to cover change.
Changeset appropiate.

Copy link

sonarcloud bot commented Aug 27, 2024

@longieirl
Copy link
Contributor

Validated locally and working as expected;

? Add FLP configuration No
? Configure advanced options No
? Please choose the target ABAP
? Select Target system https://mysyste.sap.corp:44355, client 010 (Source system)
? SAPUI5 ABAP Repository UE2EDPLYLROP
? Deployment Description 
? How do you want to enter the package? Enter manually
? Package $TMP
? How do you want to enter the transport request? Enter manually
? Transport Request 
   create project1/ui5.yaml
   create project1/.gitignore
   create project1/package.json
   create project1/ui5-local.yaml

Copy link
Contributor

@mikicvi-SAP mikicvi-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset ✅
Changes LG
Unit test to cover the change

@cianmSAP cianmSAP merged commit fc58821 into main Aug 27, 2024
13 checks passed
@cianmSAP cianmSAP deleted the fix/2128/abap-deploy-config-local-pkg branch August 27, 2024 16:16
devinea added a commit that referenced this pull request Aug 27, 2024
* origin/main:
  fix(abap-deploy-config): fix for local pkg verification (#2289)
  chore: apply latest changesets
  feat(`odata-service-inquirer`): Adds new system prompting (#2267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants