Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - ABAP deploy configuration inquirer #2128

Open
3 tasks
cianmSAP opened this issue Jul 5, 2024 · 1 comment
Open
3 tasks

FEATURE - ABAP deploy configuration inquirer #2128

cianmSAP opened this issue Jul 5, 2024 · 1 comment
Assignees
Labels
deploy feature New feature or request

Comments

@cianmSAP
Copy link
Contributor

cianmSAP commented Jul 5, 2024

As a developer,
I want to prompt a user for abap deploy configuration,
so that I updated and create the files as required for ABAP deployment

Description

The new inquirer module will provide the user with the prompts to gather the data for creating ABAP deployment configuration.

Technical Design

@sap-ux/abap-deploy-config-inquirer
Consumed as part of a yeoman generator

Acceptance Criteria

Given I have a yeoman generator (or similar inquirer module)
when I execute getPrompts
then it will return the prompt

Notes

@sap-ux/create needs to be enhanced also to incorporate the new functionality

Tasks

  • Unit Tests added
  • Test Cases defined
@cianmSAP cianmSAP added feature New feature or request deploy labels Jul 5, 2024
@cianmSAP cianmSAP self-assigned this Jul 5, 2024
@cianmSAP cianmSAP changed the title FEATURE - and ABAP deploy configuration inquirer FEATURE - ABAP deploy configuration inquirer Jul 29, 2024
@docirl
Copy link
Contributor

docirl commented Aug 9, 2024

Please include the following change to deploy config prompting for abap for package/transport prompts:

Context

  • the existing logic for 'validating' the transport request prompt (manual transport input) checked if the package provided started with $ L l T t and if so assumed the package was 'local' therefore not requiring a transport to be provided. The validation would return true for transport request manual input prompt. This is not correct, and as in the ui service generator, the package should be checked in the backend system
  • the transport request ADT api (for 'select existing transport from list') when called with a package that is 'local' will return a warning text to state the package is local and no transport request is required, instead of returning a list of transports. We can use this response to show/hide the transport prompts. I asked ADT colleagues if other api's or methods were available to check the local status, but this is the same basic method they use also.

Summary of changes

  • dont use static check of package name to validate transport request prompt
  • check if package provided is 'local' from the backend. Use transport check adt api as used already when retrieving the list of transport requests
  • if package is local, hide transport request prompts

If anything above is unclear let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants