Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(odata-service-inquirer): Adds new system prompting #2267

Merged
merged 29 commits into from
Aug 27, 2024
Merged

feat(odata-service-inquirer): Adds new system prompting #2267

merged 29 commits into from
Aug 27, 2024

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented Aug 21, 2024 •
edited
Loading

#2265

  • Adds prompts for various auth mechanisms when creating new systems
  • Returns backend system objects for persistence using @sap-ux/store (by consumer)
  • Updates ConnectionValidator to support new auth mechanisms
  • Adds mandatory property to new system name prompt
  • Fix for : Adding new ABAP OnPrem system with connection error displays warning for services (service prompt should be hidden)
  • Fix for: Yo CLI Abap On Prem continues with metadata error
  • Adds tests to cover

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5de9408

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/odata-service-inquirer Patch
@sap-ux/cap-config-writer Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IainSAP IainSAP self-assigned this Aug 21, 2024
@IainSAP IainSAP added the odata-service-inquirer @sap-ux/odata-service-inquirer label Aug 23, 2024
cianmSAP
cianmSAP approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed
New additions to @sap-ux/odata-service-inquirer look good
Tests to cover
Changeset ✅

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IainSAP IainSAP mentioned this pull request Aug 27, 2024
Closed
longieirl
longieirl approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Test coverage is good.
Detailed comments which help.

@IainSAP IainSAP merged commit 34b2606 into main Aug 27, 2024
13 checks passed
@IainSAP IainSAP deleted the feature/2265/adds_new_system_prompting branch August 27, 2024 13:45
devinea added a commit that referenced this pull request Aug 27, 2024
@devinea
Merge remote-tracking branch 'origin/main' into Add_madge
0750fcb 
* origin/main:
  fix(abap-deploy-config): fix for local pkg verification (#2289)
  chore: apply latest changesets
  feat(`odata-service-inquirer`): Adds new system prompting (#2267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longieirl longieirl longieirl approved these changes

@cianmSAP cianmSAP cianmSAP approved these changes

Assignees

@IainSAP IainSAP

Labels
odata-service-inquirer @sap-ux/odata-service-inquirer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IainSAP @longieirl @cianmSAP