regression: native emojis crowding surrounding text on Linux - #41607
regression: native emojis crowding surrounding text on Linux#41607nazabucciarelli wants to merge 2 commits into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughChangesMessage emoji styling
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41607 +/- ##
===========================================
- Coverage 68.75% 68.70% -0.05%
===========================================
Files 4150 4151 +1
Lines 159416 159491 +75
Branches 27997 27945 -52
===========================================
- Hits 109609 109581 -28
- Misses 44629 44724 +95
- Partials 5178 5186 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Closed as #41555 already addresses this issue |
Proposed changes (including videos or screenshots)
Cause: The fuselage package brings a rule that applies to all emojis in a message, not only to custom ones:
node_modules/@rocket.chat/fuselage/dist/fuselage.css)This forces a fixed box of
1.5remx1.5remwithdisplay: inline-block, but for a native emoji, if the font draws the glyph wider than that box (the case of Linux), it overflows visually, eating that margin of0.125rem.Issue(s)
CORE-2482 [Regression] Native emojis render too close to surrounding text on Linux
Steps to test or reproduce
Precondition: Being on a Linux OS
hello 😛 helloHow it shouldn't look like:
Further comments
Summary by CodeRabbit