chore: remove duplicated emoji css - #41425
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (5)
WalkthroughEmoji CSS is simplified by removing dedicated message-reaction sizing rules and retaining message-context ChangesEmoji styling
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41425 +/- ##
===========================================
+ Coverage 68.61% 68.63% +0.02%
===========================================
Files 4133 4133
Lines 160773 160773
Branches 29243 29263 +20
===========================================
+ Hits 110315 110353 +38
+ Misses 45348 45297 -51
- Partials 5110 5123 +13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
51e94c4 to
3521f80
Compare
Proposed changes (including videos or screenshots)
RocketChat/fuselage#2086 moved the emoji
font-size/line-heightrules into fuselage's own styles (MessageReactions,Messages,ThreadMessage). With that version bumped in, the matching overrides we keep inemoji.cssare now duplicated, so this removes them:.rcx-message-reactions__emojisize rules.rcx-message__emojifont-size/line-height&--bigsize rules (incl. big custom-emoji dimensions)Kept on purpose (not covered by fuselage): the
.rcx-message__emojifont-family, the global.emoji/ picker rules, and.emoji--customdimensions (image-based custom emojis still need explicit sizing).Issue(s)
Steps to test or reproduce
@rocket.chat/fuselageto the version including PR fix(fuselage): Adjust sizings for unicode emojis fuselage#2086.Further comments
Summary by CodeRabbit