Skip to content

chore: remove duplicated emoji css - #41425

Merged
dionisio-bot[bot] merged 1 commit into
developfrom
reg/remove-emoji-css
Jul 20, 2026
Merged

chore: remove duplicated emoji css#41425
dionisio-bot[bot] merged 1 commit into
developfrom
reg/remove-emoji-css

Conversation

@ricardogarim

@ricardogarim ricardogarim commented Jul 16, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

RocketChat/fuselage#2086 moved the emoji font-size/line-height rules into fuselage's own styles (MessageReactions, Messages, ThreadMessage). With that version bumped in, the matching overrides we keep in emoji.css are now duplicated, so this removes them:

  • .rcx-message-reactions__emoji size rules
  • .rcx-message__emoji font-size/line-height
  • &--big size rules (incl. big custom-emoji dimensions)

Kept on purpose (not covered by fuselage): the .rcx-message__emoji font-family, the global .emoji / picker rules, and .emoji--custom dimensions (image-based custom emojis still need explicit sizing).

Issue(s)

Steps to test or reproduce

  1. Bump @rocket.chat/fuselage to the version including PR fix(fuselage): Adjust sizings for unicode emojis fuselage#2086.
  2. Send a message with only unicode emojis (big emojis), a message with inline emojis, an emoji reaction, and a custom (image) emoji.
  3. Confirm all render correctly and unicode emojis are vertically aligned in message, reaction, and thread views.

Further comments

Review in cubic

Summary by CodeRabbit

  • Style
    • Refined emoji styling in messages and reactions.
    • Standardized emoji sizing through shared styling for a more consistent appearance.

@dionisio-bot

dionisio-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3521f80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5f799a15-ef44-4094-9adb-3beda82621d7

📥 Commits

Reviewing files that changed from the base of the PR and between 297df1a and 3521f80.

📒 Files selected for processing (1)
  • apps/meteor/app/theme/client/imports/components/emoji.css
💤 Files with no reviewable changes (1)
  • apps/meteor/app/theme/client/imports/components/emoji.css
📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: 📦 Build Packages
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build

Walkthrough

Emoji CSS is simplified by removing dedicated message-reaction sizing rules and retaining message-context font-family styling, with sizing handled by broader emoji rules.

Changes

Emoji styling

Layer / File(s) Summary
Consolidate emoji context styles
apps/meteor/app/theme/client/imports/components/emoji.css
Removes message-reaction emoji sizing declarations and retains message emoji font-family styling.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing duplicated emoji CSS rules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • CORE-2411: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.63%. Comparing base (297df1a) to head (3521f80).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41425      +/-   ##
===========================================
+ Coverage    68.61%   68.63%   +0.02%     
===========================================
  Files         4133     4133              
  Lines       160773   160773              
  Branches     29243    29263      +20     
===========================================
+ Hits        110315   110353      +38     
+ Misses       45348    45297      -51     
- Partials      5110     5123      +13     
Flag Coverage Δ
e2e 58.99% <ø> (+0.01%) ⬆️
e2e-api 45.60% <ø> (-0.04%) ⬇️
unit 70.55% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardogarim
ricardogarim force-pushed the reg/remove-emoji-css branch from 51e94c4 to 3521f80 Compare July 20, 2026 11:57
@ricardogarim ricardogarim added this to the 8.7.0 milestone Jul 20, 2026
@ricardogarim
ricardogarim marked this pull request as ready for review July 20, 2026 11:58

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jul 20, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 20, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Jul 20, 2026
Merged via the queue into develop with commit 0a1baf2 Jul 20, 2026
85 of 87 checks passed
@dionisio-bot
dionisio-bot Bot deleted the reg/remove-emoji-css branch July 20, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants