Skip to content

regression: native emojis bottom-aligned in messages - #41527

Merged
ggazzo merged 1 commit into
release-8.7.0from
regression/native-emoji-vertical-align
Jul 23, 2026
Merged

regression: native emojis bottom-aligned in messages#41527
ggazzo merged 1 commit into
release-8.7.0from
regression/native-emoji-vertical-align

Conversation

@ricardogarim

@ricardogarim ricardogarim commented Jul 22, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Root cause: the EmojiOne → native emoji migration (#39411) dropped the pre-existing vertical-align: middle from .emoji.

Native emojis (text glyphs) then fell back to baseline — sinking to the bottom of the line and inflating line height (most visible on macOS). This restores that one declaration. Custom emojis, reactions, picker, and autocomplete are unaffected.

Issue(s)

CORE-2440

Steps to test or reproduce

  1. On macOS, open any room.
  2. Send a few separate messages:
    asd 🙂 ASD
    asd
    asd
    asd 🙂
    asd
    
  3. Look at the messages that contain an emoji.
    • Before: the emoji sits low (aligned to the bottom of the line), making those messages taller and the spacing uneven.
    • After: the emoji is vertically centered with the text, and messages have consistent height/spacing.

Review in cubic

Summary by CodeRabbit

  • Style
    • Improved emoji alignment with surrounding text for a more consistent inline appearance.

@dionisio-bot

dionisio-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c7d7122

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the regression being fixed: native emojis were bottom-aligned in messages.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ricardogarim ricardogarim added this to the 8.7.0 milestone Jul 22, 2026
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.7.0@68758b1). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-8.7.0   #41527   +/-   ##
================================================
  Coverage                 ?   68.55%           
================================================
  Files                    ?     4138           
  Lines                    ?   159324           
  Branches                 ?    27930           
================================================
  Hits                     ?   109220           
  Misses                   ?    44957           
  Partials                 ?     5147           
Flag Coverage Δ
e2e 58.85% <ø> (?)
e2e-api 45.35% <ø> (?)
unit 70.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardogarim
ricardogarim marked this pull request as ready for review July 22, 2026 23:05

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@ggazzo
ggazzo merged commit 915ca08 into release-8.7.0 Jul 23, 2026
56 checks passed
@ggazzo
ggazzo deleted the regression/native-emoji-vertical-align branch July 23, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants