regression: native emojis bottom-aligned in messages - #41527
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.7.0 #41527 +/- ##
================================================
Coverage ? 68.55%
================================================
Files ? 4138
Lines ? 159324
Branches ? 27930
================================================
Hits ? 109220
Misses ? 44957
Partials ? 5147
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Root cause: the EmojiOne → native emoji migration (#39411) dropped the pre-existing
vertical-align: middlefrom.emoji.Native emojis (text glyphs) then fell back to
baseline— sinking to the bottom of the line and inflating line height (most visible on macOS). This restores that one declaration. Custom emojis, reactions, picker, and autocomplete are unaffected.Issue(s)
CORE-2440
Steps to test or reproduce
Summary by CodeRabbit