ci(fips): temporarily disable ui tests

[cardoso]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Chores
  • Updated continuous integration so the FIPS UI test job runs only when a pull request explicitly requests it via the appropriate label.
  • Adjusted the overall test completion logic to treat skipped FIPS UI tests as acceptable when they weren’t required.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: c5b3af8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The CI workflow now runs test-ui-fips only for pull requests labeled fips, while tests-done treats a skipped FIPS UI job as an acceptable result.

Changes

FIPS UI CI gating

Layer / File(s)	Summary
Label-gated FIPS test aggregation .github/workflows/ci.yml	test-ui-fips requires the fips label, and tests-done accepts either success or skipped for that job.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• RocketChat/Rocket.Chat#41473: Updates the FIPS-specific inputs passed to the same test-ui-fips job.

Suggested labels: type: chore

Suggested reviewers: ggazzo, d-gubert

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the FIPS-related CI change and the temporary UI test disablement.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• CI-2: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 992-994: Update the aggregation condition around the test-ui-fips
result so a skipped job is accepted only when the PR does not have the fips
label; when fips is present, require test-ui-fips to finish successfully and
fail for skipped or other non-success results.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 521a0f6b-f22a-4fe6-b948-5c160efeb38f

📥 Commits

Reviewing files that changed from the base of the PR and between 67e83f8 and c5b3af8.

📒 Files selected for processing (1)

• .github/workflows/ci.yml

📜 Review details

⏰ Context from checks skipped due to timeout. (4)

• GitHub Check: ⚙️ Variables Setup
• GitHub Check: CodeQL-Build
• GitHub Check: Hacktron Security Check
• GitHub Check: CodeQL-Build

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2026-04-27T18:32:21.871Z

Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 40321
File: .github/workflows/ci.yml:137-145
Timestamp: 2026-04-27T18:32:21.871Z
Learning: In .github/workflows/ci.yml, the `diff` step under `release-versions` intentionally uses a bash `if` with `gh pr diff ... | grep -q ...; then ... fi`. For non-`pull_request` workflow triggers where `GH_PR_NUM` can be empty, the `gh` command may fail, but the surrounding bash `if` is relied on to treat that failure as the condition being false and skip the `then` block, allowing the step/job to exit cleanly. Do not add extra guards for non-PR event types unless this failure/skip behavior is intentionally changed.

Applied to files:

• .github/workflows/ci.yml

🔇 Additional comments (1)

.github/workflows/ci.yml (1)

771-772: LGTM!

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Do not accept unexpected skipped FIPS UI jobs.

When the PR has the fips label, a skipped test-ui-fips job should fail aggregation; this condition currently accepts skipped results regardless of why the job was skipped.

Proposed fix

-          if [[ '${{ needs.test-ui-fips.result }}' != 'success' && '${{ needs.test-ui-fips.result }}' != 'skipped' ]]; then
+          if [[ '${{ needs.test-ui-fips.result }}' != 'success' && '${{ contains(github.event.pull_request.labels.*.name, 'fips') }}' == 'true' ]]; then
             exit 1
           fi

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml around lines 992 - 994, Update the aggregation
condition around the test-ui-fips result so a skipped job is accepted only when
the PR does not have the fips label; when fips is present, require test-ui-fips
to finish successfully and fail for skipped or other non-success results.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.59%. Comparing base (7bbb9b7) to head (c5b3af8).
⚠️ Report is 1 commits behind head on fips-ddp-streamer.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           fips-ddp-streamer   #41477      +/-   ##
=====================================================
+ Coverage              68.57%   68.59%   +0.02%     
=====================================================
  Files                   4134     4134              
  Lines                 160807   160807              
  Branches               29202    29248      +46     
=====================================================
+ Hits                  110272   110310      +38     
+ Misses                 45423    45385      -38     
  Partials                5112     5112              

Flag	Coverage Δ
unit	70.54% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.