Skip to content

ci: use separate prop for fips - #41473

Merged
cardoso merged 1 commit into
fips-ddp-streamerfrom
fips-ci
Jul 20, 2026
Merged

ci: use separate prop for fips#41473
cardoso merged 1 commit into
fips-ddp-streamerfrom
fips-ci

Conversation

@cardoso

@cardoso cardoso commented Jul 20, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Review in cubic

Summary by CodeRabbit

  • Tests
    • Updated end-to-end testing workflows to support explicit FIPS mode.
    • Improved separation of Enterprise Edition and FIPS test configuration.
    • FIPS test trace artifacts now include a dedicated suffix for easier identification.

@cardoso
cardoso requested a review from a team as a code owner July 20, 2026 10:37
@dionisio-bot

dionisio-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a8bf32c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4b9cc843-b82b-4ac6-9822-02af4cda77e8

📥 Commits

Reviewing files that changed from the base of the PR and between 878face and a8bf32c.

📒 Files selected for processing (2)
  • .github/workflows/ci-test-e2e.yml
  • .github/workflows/ci.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: CodeQL-Build
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-04-27T18:32:21.871Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 40321
File: .github/workflows/ci.yml:137-145
Timestamp: 2026-04-27T18:32:21.871Z
Learning: In .github/workflows/ci.yml, the `diff` step under `release-versions` intentionally uses a bash `if` with `gh pr diff ... | grep -q ...; then ... fi`. For non-`pull_request` workflow triggers where `GH_PR_NUM` can be empty, the `gh` command may fail, but the surrounding bash `if` is relied on to treat that failure as the condition being false and skip the `then` block, allowing the step/job to exit cleanly. Do not add extra guards for non-PR event types unless this failure/skip behavior is intentionally changed.

Applied to files:

  • .github/workflows/ci.yml
🔇 Additional comments (2)
.github/workflows/ci-test-e2e.yml (1)

29-32: LGTM!

Also applies to: 146-146, 199-206, 215-215, 233-233, 266-266, 281-281, 317-317

.github/workflows/ci.yml (1)

734-735: LGTM!

Also applies to: 755-756, 776-777


Walkthrough

The E2E workflow adds an explicit fips input, uses it for FIPS image and compose behavior, and updates FIPS CI jobs to pass release: ee with fips: true. Test environment flags and trace artifact names are adjusted accordingly.

Changes

FIPS E2E workflow

Layer / File(s) Summary
Workflow input and FIPS callers
.github/workflows/ci-test-e2e.yml, .github/workflows/ci.yml
The reusable workflow declares fips, while API, Livechat, and UI FIPS jobs pass release: ee and fips: true.
FIPS runtime selection
.github/workflows/ci-test-e2e.yml
Docker image selection, EE container startup, and service readiness now use the separate FIPS input and EE release condition.
Test mode and artifacts
.github/workflows/ci-test-e2e.yml
API and UI tests set IS_EE only for the EE release, and Playwright trace artifacts receive a FIPS suffix when enabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: type: chore

Suggested reviewers: ggazzo, kevl​​ehman

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the CI change to add a separate FIPS property and use it in workflow configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.54%. Comparing base (878face) to head (a8bf32c).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           fips-ddp-streamer   #41473   +/-   ##
==================================================
  Coverage              70.54%   70.54%           
==================================================
  Files                   1851     1851           
  Lines                 110159   110159           
  Branches               15850    15889   +39     
==================================================
+ Hits                   77709    77714    +5     
  Misses                 31805    31805           
+ Partials                 645      640    -5     
Flag Coverage Δ
unit 70.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cardoso
cardoso merged commit 295176f into fips-ddp-streamer Jul 20, 2026
55 of 56 checks passed
@cardoso
cardoso deleted the fips-ci branch July 20, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant