Skip to content

ci(fips): temporarily disable ui tests #41477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Jul 20, 2026
Merged

ci(fips): temporarily disable ui tests #41477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,8 +768,8 @@ jobs:

test-ui-fips:
name: 🔨 Test UI (FIPS)
if: contains(github.event.pull_request.labels.*.name, 'fips')
needs: [checks, build-gh-docker-publish, release-versions]

uses: ./.github/workflows/ci-test-e2e.yml
with:
type: ui
Expand Down Expand Up @@ -989,7 +989,7 @@ jobs:
exit 1
fi

if [[ '${{ needs.test-ui-fips.result }}' != 'success' ]]; then
if [[ '${{ needs.test-ui-fips.result }}' != 'success' && '${{ needs.test-ui-fips.result }}' != 'skipped' ]]; then
exit 1
fi
Comment on lines +992 to 994

@coderabbitai coderabbitai Bot Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Do not accept unexpected skipped FIPS UI jobs.

When the PR has the fips label, a skipped test-ui-fips job should fail aggregation; this condition currently accepts skipped results regardless of why the job was skipped.

Proposed fix 
-          if [[ '${{ needs.test-ui-fips.result }}' != 'success' && '${{ needs.test-ui-fips.result }}' != 'skipped' ]]; then
+          if [[ '${{ needs.test-ui-fips.result }}' != 'success' && '${{ contains(github.event.pull_request.labels.*.name, 'fips') }}' == 'true' ]]; then
             exit 1
           fi
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml around lines 992 - 994, Update the aggregation
condition around the test-ui-fips result so a skipped job is accepted only when
the PR does not have the fips label; when fips is present, require test-ui-fips
to finish successfully and fail for skipped or other non-success results.


Expand Down
Loading