Skip to content

chore(deps): bump mailparser, nodemailer, and undici, markdown-it - #41039

Merged
julio-rocketchat merged 5 commits into
developfrom
bump-dependencies-mailparser-nodemailer-undici
Jun 30, 2026
Merged

chore(deps): bump mailparser, nodemailer, and undici, markdown-it#41039
julio-rocketchat merged 5 commits into
developfrom
bump-dependencies-mailparser-nodemailer-undici

Conversation

@julio-rocketchat

@julio-rocketchat julio-rocketchat commented Jun 22, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/SB-1000

Steps to test or reproduce

Further comments

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated key runtime and build dependencies to newer compatible versions, including mailparser, nodemailer, and undici.
    • Refreshed dependency resolution rules to improve consistency across the project, including updated markdown-it and stricter undici version pinning for more predictable installs.

@julio-rocketchat
julio-rocketchat requested a review from a team as a code owner June 22, 2026 12:30
@dionisio-bot

dionisio-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6a2b865

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@julio-rocketchat julio-rocketchat added this to the 8.7.0 milestone Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 08654de1-eca6-47ae-8af9-aa0408f77fea

📥 Commits

Reviewing files that changed from the base of the PR and between 26127c3 and 6a2b865.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • apps/meteor/package.json
  • package.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/meteor/package.json
  • package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build
⚠️ CI failures not shown inline (5)

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**

GitHub Check: Dionisio QA: Some checks did not pass

Conclusion: failure

View job details

**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**

Walkthrough

Updates mailparser, nodemailer, markdown-it, and undici version pins across the Meteor app, root workspace resolutions, and a GitHub Action package manifest.

Changes

Dependency Version Updates

Layer / File(s) Summary
App mail dependency bumps
apps/meteor/package.json
Updates mailparser from ~3.9.10 to ~3.9.11, nodemailer from ^8.0.8 to ^9.0.1, and @types/nodemailer from ^8.0.0 to ^8.0.1.
Root resolution updates
package.json
Updates Yarn resolutions for markdown-it to ^14.2.0, undici to ^6.27.0, and nodemailer to ^9.0.1.
undici pinning
.github/actions/update-version-durability/package.json
Adds an npm overrides block that pins undici to 6.27.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • tassoevan
  • yasnagat
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the dependency bumps in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • SB-1000: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/meteor/package.json`:
- Line 260: Locate the `@types/nodemailer` dependency in package.json (currently
pinned at ^8.0.0) and update it to ^8.0.1 to align with the nodemailer v9.0.1
version already specified in the dependencies. Additionally, review the files
EmailInbox.ts and EmailInbox_Outgoing.ts to ensure they properly handle TLS
certificate validation, as nodemailer v9 now enforces TLS certificate validation
by default for remote content fetching (attachments, OAuth2 endpoints, proxy
connections) and may require configuration adjustments if your code uses remote
attachments or self-signed certificates.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2e63868d-e3d8-4936-ad2f-dde32440e66a

📥 Commits

Reviewing files that changed from the base of the PR and between 7b54fb7 and 990d121.

⛔ Files ignored due to path filters (2)
  • .github/actions/update-version-durability/package-lock.json is excluded by !**/package-lock.json
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • .github/actions/update-version-durability/package.json
  • apps/meteor/package.json
  • package.json
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build
🔇 Additional comments (3)
apps/meteor/package.json (1)

244-244: LGTM!

.github/actions/update-version-durability/package.json (1)

20-22: LGTM!

package.json (1)

98-99: The resolution mappings are functioning correctly. Both undici ranges converge to a single entry in yarn.lock (^6.27.0), and nodemailer is properly pinned to 9.0.1 with no unexpected range variants present.

Comment thread apps/meteor/package.json
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.87%. Comparing base (3cd7db6) to head (6a2b865).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #41039   +/-   ##
========================================
  Coverage    69.86%   69.87%           
========================================
  Files         3393     3393           
  Lines       130748   130749    +1     
  Branches     22797    22756   -41     
========================================
+ Hits         91349    91356    +7     
+ Misses       36040    36031    -9     
- Partials      3359     3362    +3     
Flag Coverage Δ
e2e 59.40% <ø> (+0.04%) ⬆️
e2e-api 45.31% <ø> (+0.03%) ⬆️
unit 69.94% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat julio-rocketchat changed the title chore(deps): bump mailparser, nodemailer, and undici chore(deps): bump mailparser, nodemailer, and undici, markdown-it Jun 30, 2026
@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Jun 30, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 30, 2026
@julio-rocketchat
julio-rocketchat merged commit 9f08d1a into develop Jun 30, 2026
80 of 85 checks passed
@julio-rocketchat
julio-rocketchat deleted the bump-dependencies-mailparser-nodemailer-undici branch June 30, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants