chore(deps): bump mailparser, nodemailer, and undici, markdown-it - #41039
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
|
| Layer / File(s) | Summary |
|---|---|
App mail dependency bumps apps/meteor/package.json |
Updates mailparser from ~3.9.10 to ~3.9.11, nodemailer from ^8.0.8 to ^9.0.1, and @types/nodemailer from ^8.0.0 to ^8.0.1. |
Root resolution updates package.json |
Updates Yarn resolutions for markdown-it to ^14.2.0, undici to ^6.27.0, and nodemailer to ^9.0.1. |
undici pinning .github/actions/update-version-durability/package.json |
Adds an npm overrides block that pins undici to 6.27.0. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
- RocketChat/Rocket.Chat#40966: Updates
nodemailerdependency versions in the same app and workspace manifests. - RocketChat/Rocket.Chat#40978: Also updates
mailparserandnodemailerinapps/meteor/package.json.
Suggested reviewers
- tassoevan
- yasnagat
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately summarizes the dependency bumps in the pull request. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (1)
- SB-1000: Request failed with status code 401
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/meteor/package.json`:
- Line 260: Locate the `@types/nodemailer` dependency in package.json (currently
pinned at ^8.0.0) and update it to ^8.0.1 to align with the nodemailer v9.0.1
version already specified in the dependencies. Additionally, review the files
EmailInbox.ts and EmailInbox_Outgoing.ts to ensure they properly handle TLS
certificate validation, as nodemailer v9 now enforces TLS certificate validation
by default for remote content fetching (attachments, OAuth2 endpoints, proxy
connections) and may require configuration adjustments if your code uses remote
attachments or self-signed certificates.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2e63868d-e3d8-4936-ad2f-dde32440e66a
⛔ Files ignored due to path filters (2)
.github/actions/update-version-durability/package-lock.jsonis excluded by!**/package-lock.jsonyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
.github/actions/update-version-durability/package.jsonapps/meteor/package.jsonpackage.json
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: Hacktron Security Check
- GitHub Check: CodeQL-Build
🔇 Additional comments (3)
apps/meteor/package.json (1)
244-244: LGTM!.github/actions/update-version-durability/package.json (1)
20-22: LGTM!package.json (1)
98-99: The resolution mappings are functioning correctly. Bothundiciranges converge to a single entry inyarn.lock(^6.27.0), andnodemaileris properly pinned to9.0.1with no unexpected range variants present.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41039 +/- ##
========================================
Coverage 69.86% 69.87%
========================================
Files 3393 3393
Lines 130748 130749 +1
Branches 22797 22756 -41
========================================
+ Hits 91349 91356 +7
+ Misses 36040 36031 -9
- Partials 3359 3362 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SB-1000
Steps to test or reproduce
Further comments
Summary by CodeRabbit
mailparser,nodemailer, andundici.markdown-itand stricterundiciversion pinning for more predictable installs.