Skip to content

chore(deps): bump hono, mailparser, nodemailer, and form-data - #40978

Merged
julio-rocketchat merged 2 commits into
developfrom
bump-hono-again
Jun 16, 2026
Merged

chore(deps): bump hono, mailparser, nodemailer, and form-data#40978
julio-rocketchat merged 2 commits into
developfrom
bump-hono-again

Conversation

@julio-rocketchat

@julio-rocketchat julio-rocketchat commented Jun 16, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/SB-998

Steps to test or reproduce

Further comments

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated the hono dependency to the latest patch release across relevant packages.
    • Updated the mailparser dependency to a newer patch version.
    • Removed a Yarn resolution override related to mailparser/nodemailer from the root configuration.

@dionisio-bot

dionisio-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8f7b37a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Updates hono from version 4.12.23 to 4.12.25 in apps/meteor and packages/http-router. Concurrently bumps mailparser from ~3.9.9 to ~3.9.10 in apps/meteor and removes the mailparser/nodemailer resolution override from the root package.json.

Changes

Dependency Version Updates

Layer / File(s) Summary
Hono version bump across packages
apps/meteor/package.json, packages/http-router/package.json
hono updated from 4.12.23 to 4.12.25 in both packages that declare it as a direct dependency.
Mailparser version bump and resolution cleanup
apps/meteor/package.json, package.json
mailparser bumped from ~3.9.9 to ~3.9.10 in apps/meteor, and the mailparser/nodemailer resolution override is removed from the root resolutions section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • RocketChat/Rocket.Chat#40966: Both PRs touch dependency version management in apps/meteor/package.json and package.json, particularly around mailparser and nodemailer resolution handling.

Suggested reviewers

  • tassoevan
  • yasnagat
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'hono, esbuild, and form-data' but the actual changeset only updates hono and mailparser—esbuild and form-data updates are not present. Update the title to accurately reflect the actual dependencies bumped: 'chore(deps): bump hono and mailparser' or provide the missing esbuild and form-data updates.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • SB-998: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@julio-rocketchat julio-rocketchat changed the title chore(deps): bump hono to 4.12.25 chore(deps): bump hono, esbuild, and form-data Jun 16, 2026
@julio-rocketchat julio-rocketchat changed the title chore(deps): bump hono, esbuild, and form-data chore(deps): bump hono and form-data Jun 16, 2026
@julio-rocketchat julio-rocketchat changed the title chore(deps): bump hono and form-data chore(deps): bump hono, mailparser, nodemailer, and form-data Jun 16, 2026
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.10%. Comparing base (228486f) to head (8f7b37a).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40978      +/-   ##
===========================================
+ Coverage    70.09%   70.10%   +0.01%     
===========================================
  Files         3357     3357              
  Lines       129543   129543              
  Branches     22456    22411      -45     
===========================================
+ Hits         90802    90817      +15     
+ Misses       35437    35428       -9     
+ Partials      3304     3298       -6     
Flag Coverage Δ
e2e 59.21% <ø> (-0.09%) ⬇️
e2e-api 47.06% <ø> (+0.86%) ⬆️
unit 70.05% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat
julio-rocketchat requested a review from a team as a code owner June 16, 2026 15:50
@julio-rocketchat julio-rocketchat added this to the 8.6.0 milestone Jun 16, 2026
@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Jun 16, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2026
@julio-rocketchat
julio-rocketchat merged commit a903f44 into develop Jun 16, 2026
152 of 159 checks passed
@julio-rocketchat
julio-rocketchat deleted the bump-hono-again branch June 16, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants