chore(deps): bump js-yaml, linkify-it, @opentelemetry/sdk-node, fast-uri, sharp, and postcss - #41537
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdates OpenTelemetry, mailparser, Sharp, PostCSS tooling, and transitive dependency resolutions, while aligning image-resize typings with Sharp’s explicit ChangesDependency and image typing updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.7.0 #41537 +/- ##
=================================================
- Coverage 68.59% 68.40% -0.19%
=================================================
Files 4138 4139 +1
Lines 159415 158311 -1104
Branches 28188 28357 +169
=================================================
- Hits 109351 108293 -1058
+ Misses 44934 44883 -51
- Partials 5130 5135 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
yasnagat
changed the title
js-yaml, linkify-it, @opentelemetry/sdk-node, fast-urijs-yaml, linkify-it, @opentelemetry/sdk-node, fast-uri, sharp
julio-rocketchat
added
the
stat: QA assured
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/meteor/package.json`:
- Line 300: Update the image resize path that constructs Sharp to explicitly
handle inputs exceeding Sharp’s five-channel limit, adding user-facing
validation or a safe fallback for multi-channel TIFF, PSD, DICOM, and JP2
uploads; add regression coverage for these formats and preserve successful
custom emoji processing for supported inputs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 39010c01-c4dc-45b7-b6b6-524d257a86e4
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
apps/meteor/package.jsonapps/meteor/server/services/image/service.tsee/apps/ddp-streamer/package.jsonpackages/core-services/src/types/IMediaService.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: cubic · AI code reviewer
⚠️ CI failures not shown inline (6)
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ✅ **QA assured**
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
packages/core-services/src/types/IMediaService.tsapps/meteor/server/services/image/service.ts
🧠 Learnings (3)
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
packages/core-services/src/types/IMediaService.tsapps/meteor/server/services/image/service.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
packages/core-services/src/types/IMediaService.tsapps/meteor/server/services/image/service.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
packages/core-services/src/types/IMediaService.tsapps/meteor/server/services/image/service.ts
🔇 Additional comments (6)
apps/meteor/package.json (3)
90-90: 🩺 Stability & AvailabilityVerify the OpenTelemetry package versions are compatible.
@opentelemetry/sdk-nodeis being moved to^0.220.0, while the directly related@opentelemetry/exporter-trace-otlp-grpcremains at^0.217.0. The tracing code uses both packages together; verify the lockfile has compatible transitive versions, or update the exporter to the matching release. OpenTelemetry documents these packages as experimental, where releases may contain breaking changes. (npmjs.com)
248-248: LGTM!
412-413: LGTM!ee/apps/ddp-streamer/package.json (1)
46-46: LGTM!packages/core-services/src/types/IMediaService.ts (1)
3-3: LGTM!Also applies to: 19-19, 28-28
apps/meteor/server/services/image/service.ts (1)
11-11: LGTM!Also applies to: 44-44, 57-57
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
e7cb452
dionisio-bot
Bot
added
the
stat: ready to merge
5f1f7d9
yasnagat
changed the title
js-yaml, linkify-it, @opentelemetry/sdk-node, fast-uri, sharpjs-yaml, linkify-it, @opentelemetry/sdk-node, fast-uri, sharp, and postcss
4 participants
Proposed changes (including videos or screenshots)
This PR bumps:
js-yaml,linkify-it,@opentelemetry/sdk-node,fast-uri,sharp, andpostcssdependencies to address related High CVEs.Issue(s)
Steps to test or reproduce
Further comments
sharp bump: 0.33.5 → 0.35.3
IMediaService.tsandimage/service.tsused import type sharp from'sharp'+sharp.FitEnum, relying on the old namespace-style types. Sharp's new bundled types (dist/index.d.mts) have no such namespace — only named exports. Changed both toimport type { FitEnum }from'sharp' + keyof FitEnum. Other files import sharp as a value (not type-only), so they're unaffected.Summary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
Chores