regression(federation): mongo url, dms etc #37653

ggazzo · 2025-12-01T14:16:56Z

Proposed changes (including videos or screenshots)

Issue(s)

FB-121

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Bug Fixes
- Enhanced federated direct message detection using dynamic participant identifier analysis instead of fixed configuration.
- Corrected Matrix event payload structure handling for improved federation compatibility.
- Refined database configuration initialization for federation setup.
Chores
- Updated federation SDK dependency to version 0.3.2 across all packages.
- Integrated QASE test reporting into CI pipeline for enhanced test analytics and traceability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…tiple packages

Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>

…ing (#37570)

dionisio-bot · 2025-12-01T14:17:00Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-12-01T14:17:01Z

⚠️ No Changeset found

Latest commit: 80d802c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-01T14:37:17Z

Caution

Review failed

The pull request is closed.

Walkthrough

This PR consolidates federation regression fixes and test enhancements per issue FB-121. Updates @rocket.chat/federation-sdk to 0.3.2, fixes MongoDB URL parsing in federation setup, corrects remote profile queries, adjusts DM federated member detection, updates Matrix event typings, adds Qase CI integration, and expands federation end-to-end tests for media handling and direct messages.

Changes

Cohort / File(s)	Summary
Federation SDK dependency updates `apps/meteor/package.json`, `ee/packages/federation-matrix/package.json`, `packages/core-services/package.json`	Bumped `@rocket.chat/federation-sdk` from 0.3.0 to 0.3.2 across three packages.
CI and Qase integration `.github/workflows/ci.yml`, `package.json`	Added `QASE_TESTOPS_JEST_API_TOKEN` environment variable to integration and federation test steps; added `jest-qase-reporter` devDependency v^2.1.3.
Jest Qase configuration `ee/packages/federation-matrix/jest.config.federation.ts`, `ee/packages/federation-matrix/tests/setup-qase.ts`	Added `setupFilesAfterEnv` and conditional Qase reporter to federation Jest config; introduced setup file that wraps describe/it/test to auto-register suites with Qase when token is present.
DM and room federation detection `apps/meteor/app/lib/server/functions/createRoom.ts`, `apps/meteor/server/methods/createDirectMessage.ts`	Added ESLint disable and TODO notes in createRoom; updated createDirectMessage to dynamically detect federated members (usernames with ':' and '@') and set `federated: true` flag accordingly instead of hardcoded false.
Federation setup and profile query fixes `ee/packages/federation-matrix/src/setup.ts`, `ee/packages/federation-matrix/src/FederationMatrix.ts`	Inlined MongoDB URI resolution in setup.ts; changed FederationMatrix.verifyMatrixIds to pass full matrixId as userId to `federationSDK.queryProfileRemote` instead of local portion.
Matrix event structure and typing updates `ee/packages/federation-matrix/src/events/room.ts`, `ee/packages/federation-matrix/src/helpers/message.parsers.ts`	Updated room event handler to destructure from event object structure; updated MatrixMessageContent type to reference event.content path instead of content.
Test helper additions `apps/meteor/tests/data/file.helper.ts`, `ee/packages/federation-matrix/tests/helper/synapse-client.ts`	Added three RC file helpers: `uploadFileToRC`, `getFilesList`, `downloadFileAndVerifyBinary`; added four SynapseClient methods: `uploadFile`, `getRoomFileMessages`, `findFileMessageInRoom`, `downloadFileAndCompareBinary` for federation media testing.
Federation end-to-end test expansions `ee/packages/federation-matrix/tests/end-to-end/messaging.spec.ts`, `ee/packages/federation-matrix/tests/end-to-end/room.spec.ts`	Added comprehensive Media test suite covering RC and Element file uploads/downloads for image, PDF, video, audio, and text; added IRequestConfig typing and per-test user lifecycle (create/delete) for DM federation tests; removed hardcoded waits.
Test infrastructure cleanup `ee/packages/federation-matrix/tests/helper/ddp-listener.ts`, `ee/packages/federation-matrix/tests/resources/sample_text.txt`	Removed debug console.log statements from DDP listener; added sample_text.txt resource file for media tests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

DM federation detection logic (createDirectMessage.ts): Verify the hasFederatedMembers detection correctly identifies ':' and '@' patterns; ensure it doesn't break non-federated DM creation or introduce false positives.
Matrix profile query parameter change (FederationMatrix.ts): Confirm passing full matrixId instead of local portion aligns with updated federation-sdk 0.3.2 API expectations and doesn't regress remote profile lookups.
Event structure changes (room.ts, message.parsers.ts): Validate event object destructuring matches updated EventEmitter emit payload shape and that type references are correct.
Qase setup complexity (setup-qase.ts): Review the describe/it/test wrapping logic, stack management, and restoration behavior to ensure proper test registration and no side effects between test suites.
MongoDB URI inlining (setup.ts): Confirm that process.env.MONGO_URL || 'mongodb://localhost:3001/meteor' correctly handles the connection without dbName extraction and integrates properly with the federation SDK.

Possibly related PRs

fix(federation): query profile using wrong param #37640: Directly modifies FederationMatrix.ts to pass full matrixId as userId to federationSDK.queryProfileRemote — same core regression fix for profile queries.
regression(federation): DM detection in createDirectMessage #37582: Modifies createDirectMessage to detect federated participants and set the federated flag — same DM federation detection logic.
test: message media tests #37528: Adds identical test helpers and federation media end-to-end tests (file.helper.ts, messaging.spec.ts, synapse-client methods, Qase setup) — overlapping test infrastructure.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

rodrigok
sampaiodiego
ricardogarim

Poem

🐰 Federation fixes hop into place,
SDK bumped at a steady pace,
Mongo URLs parse without a hitch,
DMs detect federated rich,
Tests with Qase now certified—
Quality assured, all tested wide! ✨

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/fed-regressions

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d19bb8a and 80d802c.

⛔ Files ignored due to path filters (4)

ee/packages/federation-matrix/tests/resources/sample_audio.mp3 is excluded by !**/*.mp3
ee/packages/federation-matrix/tests/resources/sample_pdf.pdf is excluded by !**/*.pdf
ee/packages/federation-matrix/tests/resources/sample_video.webm is excluded by !**/*.webm
yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (19)

.github/workflows/ci.yml (1 hunks)
apps/meteor/app/lib/server/functions/createRoom.ts (2 hunks)
apps/meteor/package.json (1 hunks)
apps/meteor/server/methods/createDirectMessage.ts (2 hunks)
apps/meteor/tests/data/file.helper.ts (1 hunks)
ee/packages/federation-matrix/jest.config.federation.ts (1 hunks)
ee/packages/federation-matrix/package.json (1 hunks)
ee/packages/federation-matrix/src/FederationMatrix.ts (1 hunks)
ee/packages/federation-matrix/src/events/room.ts (1 hunks)
ee/packages/federation-matrix/src/helpers/message.parsers.ts (1 hunks)
ee/packages/federation-matrix/src/setup.ts (1 hunks)
ee/packages/federation-matrix/tests/end-to-end/messaging.spec.ts (2 hunks)
ee/packages/federation-matrix/tests/end-to-end/room.spec.ts (4 hunks)
ee/packages/federation-matrix/tests/helper/ddp-listener.ts (0 hunks)
ee/packages/federation-matrix/tests/helper/synapse-client.ts (2 hunks)
ee/packages/federation-matrix/tests/resources/sample_text.txt (1 hunks)
ee/packages/federation-matrix/tests/setup-qase.ts (1 hunks)
package.json (1 hunks)
packages/core-services/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

… manual URL parsing (#37571)

github-actions · 2025-12-01T17:40:11Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.2GiB	1.2GiB	+38MiB
rocketchat	368MiB	347MiB	+21MiB
omnichannel-transcript-service	141MiB	132MiB	+8.8MiB
queue-worker-service	141MiB	132MiB	+8.8MiB
ddp-streamer-service	127MiB	127MiB	+70KiB
account-service	114MiB	114MiB	+53KiB
stream-hub-service	111MiB	111MiB	+66KiB
authorization-service	111MiB	111MiB	+58KiB
presence-service	111MiB	111MiB	+55KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 15:59", "12/01 17:40 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.14]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.14]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.36]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 10 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37653
Baseline: develop
Timestamp: 2025-12-01 17:40:10 UTC
Historical data points: 10

Updated: Mon, 01 Dec 2025 17:40:11 GMT

codecov · 2025-12-01T18:05:33Z

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-7.13.0@d19bb8a). Learn more about missing BASE report.

Additional details and impacted files

@@                Coverage Diff                @@
##             release-7.13.0   #37653   +/-   ##
=================================================
  Coverage                  ?   68.91%           
=================================================
  Files                     ?     3360           
  Lines                     ?   114278           
  Branches                  ?    20562           
=================================================
  Hits                      ?    78752           
  Misses                    ?    33431           
  Partials                  ?     2095

Flag	Coverage Δ
e2e	`57.42% <ø> (?)`
e2e-api	`42.46% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This pull request addresses regressions in federation functionality by updating the federation SDK, fixing MongoDB configuration issues, adding comprehensive media file upload tests, and integrating Qase test reporting.

Key changes:

Updates @rocket.chat/federation-sdk from 0.3.0 to 0.3.2 and related event handler signatures
Fixes MongoDB URL handling in federation setup by removing unnecessary intermediate variables
Adds comprehensive media file upload tests for federated rooms (images, PDFs, videos, audio, text files)
Integrates Qase test reporting infrastructure for better test management
Implements DM federation detection based on Matrix-style user IDs

Reviewed changes

Copilot reviewed 19 out of 24 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
yarn.lock	Updates federation-sdk and adds jest-qase-reporter dependencies
package.json (root)	Adds jest-qase-reporter dev dependency
packages/core-services/package.json	Updates federation-sdk to 0.3.2
ee/packages/federation-matrix/package.json	Updates federation-sdk to 0.3.2
apps/meteor/package.json	Updates federation-sdk to 0.3.2
ee/packages/federation-matrix/src/setup.ts	Simplifies MongoDB URL handling
ee/packages/federation-matrix/src/helpers/message.parsers.ts	Updates type path for event content
ee/packages/federation-matrix/src/events/room.ts	Updates event handler to use new SDK signature
ee/packages/federation-matrix/src/FederationMatrix.ts	Fixes variable reference bug (userId → matrixId)
apps/meteor/server/methods/createDirectMessage.ts	Adds federation detection for DMs
apps/meteor/app/lib/server/functions/createRoom.ts	Adds complexity eslint disable comment
ee/packages/federation-matrix/tests/setup-qase.ts	Adds Qase test reporter setup
ee/packages/federation-matrix/tests/helper/synapse-client.ts	Adds file upload/download methods
ee/packages/federation-matrix/tests/helper/ddp-listener.ts	Removes debug console.log statements
ee/packages/federation-matrix/tests/end-to-end/room.spec.ts	Adds DM creation tests
ee/packages/federation-matrix/tests/end-to-end/messaging.spec.ts	Adds comprehensive media upload tests
ee/packages/federation-matrix/tests/resources/*	Adds test media files
ee/packages/federation-matrix/jest.config.federation.ts	Configures Qase reporter
.github/workflows/ci.yml	Adds QASE_TESTOPS_JEST_API_TOKEN secret

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ggazzo and others added 5 commits December 1, 2025 11:14

chore: update @rocket.chat/federation-sdk to version 0.3.2 across mul…

a820a7c

…tiple packages

fix(federation): query profile using wrong param (#37640)

fc0b7f3

test: message media tests (#37528)

5dbdd1a

regression(federation): DM detection in createDirectMessage (#37582)

22af924

Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>

chore(federation): update typings to match EventEmitter property prun…

3df419f

…ing (#37570)

chore(federation): rely on MongoDB client to parse db name instead of…

80d802c

… manual URL parsing (#37571)

ggazzo added this to the 7.13.0 milestone Dec 1, 2025

ggazzo marked this pull request as ready for review December 2, 2025 21:40

ggazzo requested review from a team as code owners December 2, 2025 21:40

Copilot AI review requested due to automatic review settings December 2, 2025 21:40

sampaiodiego approved these changes Dec 2, 2025

View reviewed changes

Copilot started reviewing on behalf of ggazzo December 2, 2025 21:41 View session

ggazzo merged commit fc2d609 into release-7.13.0 Dec 2, 2025
55 of 56 checks passed

ggazzo deleted the chore/fed-regressions branch December 2, 2025 21:41

Copilot finished reviewing on behalf of ggazzo December 2, 2025 21:41

Copilot AI reviewed Dec 2, 2025

View reviewed changes

This was referenced Dec 17, 2025

Upgrading from 7.11.2 to 7.13.1 Application Crash #37863

Open

feat(federation): add improved errors messaging #37581

Open

coderabbitai bot mentioned this pull request Dec 29, 2025

regression: federated messages out of order #37999

Merged

coderabbitai bot mentioned this pull request Jan 7, 2026

regression(federation): use send_leave version 2 #38066

Merged

coderabbitai bot mentioned this pull request Jan 14, 2026

chore: Remove debug flag from Jest configuration and adjust error han… #38175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression(federation): mongo url, dms etc #37653

regression(federation): mongo url, dms etc #37653

Uh oh!

ggazzo commented Dec 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

Review failed

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

codecov bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

regression(federation): mongo url, dms etc #37653

regression(federation): mongo url, dms etc #37653

Uh oh!

Conversation

ggazzo commented Dec 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

github-actions bot commented Dec 1, 2025

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

codecov bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ggazzo commented Dec 1, 2025 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Dec 1, 2025 •

edited

Loading

changeset-bot bot commented Dec 1, 2025 •

edited

Loading

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

codecov bot commented Dec 1, 2025 •

edited

Loading