test: message media tests #37528

dhulke · 2025-11-15T19:28:29Z

Proposed changes (including videos or screenshots)

Media messaging integration tests

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Tests
- Added file upload/list/download helpers and extensive end-to-end media tests covering multiple file types, cross-view checks, and binary verification.
CI
- Integrated optional Qase test reporting into CI and Jest when a token is present.
Chores
- Removed noisy debug logs and added a sample text resource.
Dev tooling
- Added a Jest Qase reporter dev dependency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…nd pre-built federation integration tests

…issue with temp build dir

…e for pem files

… script

…igurations

…e room

github-actions · 2025-11-17T19:02:48Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.2GiB	1.2GiB	+13MiB
rocketchat	359MiB	347MiB	+13MiB
omnichannel-transcript-service	132MiB	132MiB	-196B
queue-worker-service	132MiB	132MiB	-641B
ddp-streamer-service	127MiB	127MiB	+1.0KiB
account-service	114MiB	114MiB	-161B
stream-hub-service	111MiB	111MiB	+208B
authorization-service	111MiB	111MiB	+565B
presence-service	111MiB	111MiB	-276B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "11/29 18:24 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 9 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37528
Baseline: develop
Timestamp: 2025-11-29 18:24:28 UTC
Historical data points: 9

Updated: Sat, 29 Nov 2025 18:24:28 GMT

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (5)

ee/packages/federation-matrix/tests/setup-qase.ts (4)

54-70: Consider proper typing for test function parameters.

The parameters are typed as any, which bypasses TypeScript's type safety. Additionally, the wrapper converts all test functions to async, which changes the execution semantics for synchronous tests.

Apply this diff to improve type safety:

-	global.it = ((testName: any, fn?: any, timeout?: number) => {
+	global.it = ((testName: string | Function, fn?: jest.ProvidesCallback, timeout?: number) => {
 		// Handle qase-wrapped test names (qase returns a string)
 		if (typeof testName === 'string' && fn) {
 			return currentIt(
 				testName,
-				async () => {
+				() => {
 					// Set suite immediately at the start of the test
 					qase.suite(currentPath);
-					// Call the original test function and return the result
-					return fn();
+					return fn.call(this);
 				},
 				timeout,
 			);
 		}
-		// Handle cases where testName might be a number or other type
 		return currentIt(testName, fn, timeout);
 	}) as typeof global.it;

73-87: Consider proper typing for test function parameters.

Same issue as with it() - the parameters use any and the wrapper forces async execution.

Apply this diff:

-	global.test = ((testName: any, fn?: any, timeout?: number) => {
+	global.test = ((testName: string | Function, fn?: jest.ProvidesCallback, timeout?: number) => {
 		if (typeof testName === 'string' && fn) {
 			return currentTest(
 				testName,
-				async () => {
+				() => {
 					// Set suite immediately at the start of the test
 					qase.suite(currentPath);
-					// Call the original test function and return the result
-					return fn();
+					return fn.call(this);
 				},
 				timeout,
 			);
 		}
 		return currentTest(testName, fn, timeout);
 	}) as typeof global.test;

42-95: Add error handling to ensure global state is restored.

If fn() throws an exception, the original it and test functions won't be restored, potentially affecting subsequent describe blocks.

Apply this diff:

 	originalDescribe(name, () => {
 		// Add beforeEach to set suite for all tests in this describe block
 		// This must be called before the test runs so the reporter picks it up
 		global.beforeEach(() => {
 			qase.suite(currentPath);
 		});

 		// Store current it and test wrappers (they might be wrapped by parent describe)
 		const currentIt = global.it;
 		const currentTest = global.test;

 		// Wrap it() to automatically set suite at the very start
 		global.it = ((testName: any, fn?: any, timeout?: number) => {
 			// Handle qase-wrapped test names (qase returns a string)
 			if (typeof testName === 'string' && fn) {
 				return currentIt(
 					testName,
 					async () => {
 						// Set suite immediately at the start of the test
 						qase.suite(currentPath);
 						// Call the original test function and return the result
 						return fn();
 					},
 					timeout,
 				);
 			}
 			// Handle cases where testName might be a number or other type
 			return currentIt(testName, fn, timeout);
 		}) as typeof global.it;

 		// Wrap test() to automatically set suite at the very start
 		global.test = ((testName: any, fn?: any, timeout?: number) => {
 			if (typeof testName === 'string' && fn) {
 				return currentTest(
 					testName,
 					async () => {
 						// Set suite immediately at the start of the test
 						qase.suite(currentPath);
 						// Call the original test function and return the result
 						return fn();
 					},
 					timeout,
 				);
 			}
 			return currentTest(testName, fn, timeout);
 		}) as typeof global.test;

-		// Execute the describe block
-		fn();
-
-		// Restore previous wrappers
-		global.it = currentIt;
-		global.test = currentTest;
+		try {
+			// Execute the describe block
+			fn();
+		} finally {
+			// Restore previous wrappers
+			global.it = currentIt;
+			global.test = currentTest;
+		}
 	});

45-47: Redundant qase.suite() calls.

The suite is set in beforeEach (lines 45-47) and then set again at the start of each test wrapper (lines 61, 79). This appears redundant - if beforeEach already sets the suite before each test, the additional calls inside the test wrappers may be unnecessary.

Consider removing either the beforeEach hook or the calls inside the test wrappers, depending on which approach is more reliable for the Qase reporter.

ee/packages/federation-matrix/jest.config.federation.ts (1)

28-46: Consider extracting reporter configuration for better maintainability.

The conditional spreading with type assertions works but is somewhat fragile. If the jest-qase-reporter API changes, the type assertion at line 43 won't catch it.

Consider extracting the reporter configuration:
const qaseReporter = process.env.QASE_TESTOPS_JEST_API_TOKEN
	? [
			'jest-qase-reporter',
			{
				mode: 'testops',
				testops: {
					api: { token: process.env.QASE_TESTOPS_JEST_API_TOKEN },
					project: 'RC',
					run: { complete: true },
				},
				debug: true,
			},
		] as const
	: null;

const reporters: Config['reporters'] = ['default', ...(qaseReporter ? [qaseReporter] : [])];
This separates concerns and makes the configuration easier to read and maintain.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9e97b36 and 975fd4f.

📒 Files selected for processing (6)

.github/workflows/ci.yml (1 hunks)
ee/packages/federation-matrix/jest.config.federation.ts (1 hunks)
ee/packages/federation-matrix/tests/end-to-end/room.spec.ts (0 hunks)
ee/packages/federation-matrix/tests/helper/ddp-listener.ts (0 hunks)
ee/packages/federation-matrix/tests/setup-qase.ts (1 hunks)
package.json (1 hunks)

💤 Files with no reviewable changes (2)

ee/packages/federation-matrix/tests/end-to-end/room.spec.ts
ee/packages/federation-matrix/tests/helper/ddp-listener.ts

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

ee/packages/federation-matrix/tests/setup-qase.ts
ee/packages/federation-matrix/jest.config.federation.ts

🧠 Learnings (9)