Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 28, 2025

Proposed changes (including videos or screenshots)

Issue(s)

FB-119

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Bug Fixes

  • Fixed remote profile query handling in federated environments to correctly use complete identity information for profile lookups.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 28, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025

⚠️ No Changeset found

Latest commit: 51e54f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Walkthrough

The PR modifies the verifyMatrixIds method in the FederationMatrix module to pass the complete matrix ID (rather than just the username portion) to the remote profile query function, affecting how matrix identities are verified in federated contexts.

Changes

Cohort / File(s) Change Summary
Federation Matrix Identity Verification
ee/packages/federation-matrix/src/FederationMatrix.ts
Updated verifyMatrixIds method to pass full matrixId as userId parameter to federationSDK.queryProfileRemote instead of only the user portion; homeserver URL reference remains unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single file with localized parameter change to a function call
  • No logic modifications or error handling changes
  • Potential areas of focus: verify that the full matrix ID format is correctly handled by the remote profile query endpoint and confirm downstream consumers expect this parameter format

Possibly related PRs

Suggested labels

stat: QA assured

Suggested reviewers

  • ggazzo
  • juliajforesti
  • rodrigok

Poem

🐰 A matrix ID, now complete and whole,
No partial usernames take their toll,
Fed federation hops with wisdom true,
The full address makes queries new,
In quantum hoppy bounds we brew! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main fix: correcting an incorrect parameter in the federation profile query functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch federation-fix-query-profile-remote

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 358MiB 346MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB -534B
queue-worker-service 132MiB 132MiB +433B
ddp-streamer-service 127MiB 127MiB +354B
account-service 114MiB 114MiB -477B
stream-hub-service 111MiB 111MiB +332B
authorization-service 111MiB 111MiB +99B
presence-service 111MiB 111MiB -1.1KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 13:55 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 8 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37640
  • Baseline: develop
  • Timestamp: 2025-11-28 13:55:31 UTC
  • Historical data points: 8

Updated: Fri, 28 Nov 2025 13:55:32 GMT

@sampaiodiego sampaiodiego force-pushed the federation-fix-query-profile-remote branch from cf1c725 to 51e54f0 Compare December 1, 2025 13:12
@sampaiodiego sampaiodiego marked this pull request as ready for review December 1, 2025 13:12
@ggazzo ggazzo added this to the 7.13.0 milestone Dec 1, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Dec 1, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 1, 2025
@ggazzo ggazzo merged commit 42bb8a3 into develop Dec 1, 2025
21 checks passed
@ggazzo ggazzo deleted the federation-fix-query-profile-remote branch December 1, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants