chore(ui-video-conf): Review build configuration

[tassoevan]

Proposed changes (including videos or screenshots)

It uses standard ESLint configuration and enables SWC compiler on Storybook for @rocket.chat/ui-video-conf.

Issue(s)

ARCH-1886

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Chores
  • Migrated build tooling to use SWC compiler instead of Babel for improved transpilation performance in Storybook.
  • Streamlined ESLint configuration by adopting standardized presets and removing custom linting rules.
  • Cleaned up build dependencies by removing unnecessary Babel-related packages.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 7.14.0, but it targets 7.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 466ce12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The ui-video-conf package's build configuration transitions from Babel to SWC. Changes include removing .babelrc.json, updating Storybook to use SWC addon, removing @babel/core dependency, simplifying ESLint configuration, and converting a value import to a type-only import.

Changes

Cohort / File(s)	Change Summary
Build Configuration & Tool Migration packages/ui-video-conf/.babelrc.json, packages/ui-video-conf/.storybook/main.ts, packages/ui-video-conf/package.json	Deleted Babel config file; replaced Storybook's babel-based addon-webpack5-compiler with SWC-based addon-webpack5-compiler-swc; removed @babel/core devDependency
ESLint Configuration packages/ui-video-conf/.eslintignore, packages/ui-video-conf/.eslintrc.json	Removed .storybook re-include negation from ignore rules; simplified ESLint config to extend only Rocket.Chat configurations with updated ignorePatterns
Type Import Optimization packages/ui-video-conf/src/VideoConfPopup/VideoConfPopupSkeleton.tsx	Converted ComponentProps import from value import to type-only import

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify SWC addon version compatibility with Storybook and that it's compatible with the project's webpack configuration
• Confirm that builds and Storybook generation complete successfully after these changes
• Ensure TypeScript correctly recognizes the type-only import pattern

Possibly related PRs

• chore(web-ui-registration): Review build configuration #37584 — Applies the same build configuration changes: removes per-package .babelrc, migrates Storybook from Babel to SWC addon, and removes Babel devDependencies.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• MartinSchoeler

Poem

🐰 A hop from Babel's transpiling ways,
To SWC's swifter blaze,
Type imports now so lean and clean,
The fastest build you've ever seen! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main objective: reviewing and updating the build configuration for the ui-video-conf package, which aligns with the Babel removal, ESLint simplification, and SWC compiler adoption.
Linked Issues check	✅ Passed	The PR changes align with the stated objective to review build configuration: Babel config removed, ESLint simplified to standard config, and SWC compiler enabled for Storybook in ui-video-conf.
Out of Scope Changes check	✅ Passed	All changes are within scope: the only file modification outside configuration is converting a React import to type-only in VideoConfPopupSkeleton.tsx, which is a standard optimization accompanying build tool consolidation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/ui-video-conf-build-configuration

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5ef03e2 and 466ce12.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (6)

• packages/ui-video-conf/.babelrc.json (0 hunks)
• packages/ui-video-conf/.eslintignore (0 hunks)
• packages/ui-video-conf/.eslintrc.json (1 hunks)
• packages/ui-video-conf/.storybook/main.ts (1 hunks)
• packages/ui-video-conf/package.json (1 hunks)
• packages/ui-video-conf/src/VideoConfPopup/VideoConfPopupSkeleton.tsx (1 hunks)

💤 Files with no reviewable changes (2)

• packages/ui-video-conf/.eslintignore
• packages/ui-video-conf/.babelrc.json

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.

🔇 Additional comments (4)

packages/ui-video-conf/src/VideoConfPopup/VideoConfPopupSkeleton.tsx (1)

2-2: Type import usage matches how ComponentProps is consumed

ComponentProps is only used in the props type alias, so marking it as a type import is correct and has no runtime impact. Looks good.

Please just confirm tsc and Storybook builds still pass for this file after the change.

packages/ui-video-conf/package.json (1)

35-58: SWC compiler addon dependency aligns with Storybook config

Adding @storybook/addon-webpack5-compiler-swc here matches the addon name used in .storybook/main.ts, so the dependency wiring looks consistent.

Please double‑check in Storybook’s docs that @storybook/addon-webpack5-compiler-swc@~3.0.0 is the recommended range for your storybook and @storybook/react-webpack5 versions before merging.

packages/ui-video-conf/.storybook/main.ts (1)

7-12: Addon swap to SWC compiler is consistent with dependencies

The addons array now references @storybook/addon-webpack5-compiler-swc, which matches the new devDependency; the resolution helper remains the same, so wiring looks correct.

After installing deps, please run Storybook (pnpm storybook/equivalent) for this package to ensure the SWC compiler addon loads and compiles stories without errors.

packages/ui-video-conf/.eslintrc.json (1)

2-3: Simplified ESLint config is aligned with shared presets

Extending the shared base + React configs and limiting ignorePatterns to build artifacts (while re‑including .storybook) keeps this package consistent with central linting rules.

Please confirm that .eslintignore for this package doesn’t unintentionally override the !.storybook pattern if you intend to lint the Storybook config files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change	Percent
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	347MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	+574B
queue-worker-service	132MiB	132MiB	+228B
ddp-streamer-service	127MiB	127MiB	+554B
account-service	114MiB	114MiB	+2.9KiB
stream-hub-service	111MiB	111MiB	-381B
authorization-service	111MiB	111MiB	+383B
presence-service	111MiB	111MiB	+45B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 12:18 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Loading

Statistics (last 6 days):

• 📊 Average: 1.5GiB
• ⬇️ Minimum: 1.2GiB
• ⬆️ Maximum: 1.6GiB
• 🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

• Tag: pr-37586
• Baseline: develop
• Timestamp: 2025-11-24 12:18:03 UTC
• Historical data points: 6

---

Updated: Mon, 24 Nov 2025 12:18:03 GMT

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.86%. Comparing base (5ef03e2) to head (466ce12).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37586      +/-   ##
===========================================
- Coverage    68.86%   68.86%   -0.01%     
===========================================
  Files         3360     3360              
  Lines       114339   114338       -1     
  Branches     20560    20560              
===========================================
- Hits         78741    78740       -1     
- Misses       33502    33504       +2     
+ Partials      2096     2094       -2     

Flag	Coverage Δ
e2e	57.39% <ø> (-0.02%)	⬇️
e2e-api	42.23% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.