Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 4, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Switch Storybook across the repo from a Babel-based webpack5 compiler to an SWC-based webpack5 compiler, updating Storybook addons and devDependencies for more consistent, faster Storybook builds and unified compiler behavior across packages.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 4, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2025

⚠️ No Changeset found

Latest commit: f0bd388

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.14.0 milestone Dec 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Walkthrough

This PR replaces Storybook's webpack5 compiler addon from the Babel-based package to the SWC-based package across multiple packages, updates Storybook main config entries, removes local re-exports of the Babel preset where present, and updates devDependencies to @storybook/addon-webpack5-compiler-swc (~3.0.0).

Changes

Cohort / File(s) Summary
apps/meteor
apps/meteor/.storybook/main.ts, apps/meteor/package.json
Replaced Storybook webpack5 compiler addon from Babel to SWC; updated devDependency to @storybook/addon-webpack5-compiler-swc (~3.0.0).
ee/packages/pdf-worker
ee/packages/pdf-worker/.storybook/main.ts, ee/packages/pdf-worker/package.json
Swapped Storybook webpack5 compiler addon from Babel to SWC; updated devDependency to @storybook/addon-webpack5-compiler-swc (~3.0.0).
packages/fuselage-ui-kit
packages/fuselage-ui-kit/.storybook/main.ts, packages/fuselage-ui-kit/.storybook/webpackAddon.ts, packages/fuselage-ui-kit/package.json
Replaced local ./webpackAddon entry with SWC compiler addon; removed export * from '@storybook/addon-webpack5-compiler-babel/preset'; updated devDependency to SWC.
packages/gazzodown
packages/gazzodown/.storybook/main.ts, packages/gazzodown/.storybook/webpackAddon.ts, packages/gazzodown/package.json
Replaced local webpackAddon entry with SWC compiler addon; removed Babel preset re-export; updated devDependency to SWC (~3.0.0).
packages/livechat
packages/livechat/.storybook/main.ts, packages/livechat/package.json
Replaced Babel webpack5 compiler addon with SWC in Storybook config and devDependencies.
packages/storybook-config
packages/storybook-config/src/main.ts, packages/storybook-config/package.json
Swapped Storybook webpack5 compiler addon path to SWC and updated devDependency to @storybook/addon-webpack5-compiler-swc (~3.0.0).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Repeated, homogeneous dependency/configuration replacements across packages.
  • Files to spot-check:
    • .storybook/main.ts entries for correct addon paths.
    • webpackAddon.ts files for removal of Babel preset re-exports.
    • package.json devDependency versions and consistency.

Possibly related PRs

Suggested labels

stat: ready to merge

Suggested reviewers

  • ggazzo

Poem

🐰 From Babel's slow hop to SWC's quick leap,
Storybook wakes early, no time for sleep.
I nibble the changes with floppy delight,
Faster stories now race through the night! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing Babel with SWC for Storybook's webpack5 compiler across multiple packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/use-webpack5-compiler-swc

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cdf9504 and 9bc5246.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • apps/meteor/package.json (1 hunks)
  • packages/fuselage-ui-kit/package.json (1 hunks)
  • packages/livechat/package.json (1 hunks)
  • packages/storybook-config/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/meteor/package.json
  • packages/livechat/package.json
  • packages/storybook-config/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: check
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (1)
packages/fuselage-ui-kit/package.json (1)

70-70: Addon is compatible and properly configured; consider cleaning up unused Babel dependencies.

The SWC compiler addon @storybook/addon-webpack5-compiler-swc@3.0.0 is compatible with Storybook 8.6.14, and the .storybook/main.ts has already been properly updated to register it. However, the Babel dependencies (@babel/core, @babel/preset-env, @babel/preset-react, @babel/preset-typescript, babel-loader, and .babelrc.json) are still present in the package but unused in the source code. Since Storybook 8's webpack5 builder uses SWC by default, these can be safely removed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 359MiB 348MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB -1.4KiB
queue-worker-service 132MiB 132MiB -741B
ddp-streamer-service 126MiB 126MiB -512B
account-service 113MiB 113MiB -1.5KiB
stream-hub-service 111MiB 111MiB -1.5KiB
authorization-service 111MiB 111MiB -1.4KiB
presence-service 111MiB 111MiB -1.7KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 18:59", "12/05 19:35 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 14 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37696
  • Baseline: develop
  • Timestamp: 2025-12-05 19:35:35 UTC
  • Historical data points: 14

Updated: Fri, 05 Dec 2025 19:35:36 GMT

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.78%. Comparing base (48953d2) to head (f0bd388).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37696      +/-   ##
===========================================
- Coverage    67.79%   67.78%   -0.01%     
===========================================
  Files         3449     3449              
  Lines       114030   114030              
  Branches     20963    20963              
===========================================
- Hits         77305    77296       -9     
- Misses       34606    34616      +10     
+ Partials      2119     2118       -1     
Flag Coverage Δ
e2e 57.24% <ø> (-0.03%) ⬇️
e2e-api 42.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review December 4, 2025 14:54
@dougfabris dougfabris requested review from a team as code owners December 4, 2025 14:54
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Dec 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 4, 2025
tassoevan
tassoevan previously approved these changes Dec 5, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 5, 2025
@dougfabris dougfabris added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Dec 5, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 5, 2025
@dougfabris dougfabris requested a review from tassoevan December 5, 2025 18:53
@kodiakhq kodiakhq bot merged commit 5d32f73 into develop Dec 5, 2025
85 of 88 checks passed
@kodiakhq kodiakhq bot deleted the chore/use-webpack5-compiler-swc branch December 5, 2025 20:42
@dougfabris dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants