chore: Apply eslint-plugin-storybook consistently across packages

[tassoevan]

Proposed changes (including videos or screenshots)

It adds eslint-plugin-storybook as a dependency consistently in packages that were dependent on it.

Issue(s)

ARCH-1890

Steps to test or reproduce

Further comments

It don't believe this plugin is doing much yet, but positioning it here is important for future Storybook upgrades.

Summary by CodeRabbit

• Chores
  • Enhanced linting configurations across multiple development packages to enforce additional code quality standards and best practices.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 7.14.0, but it targets 7.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: b08cf4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This PR applies eslint-plugin-storybook configuration consistently across multiple packages. Changes include adding "plugin:storybook/recommended" to ESLint extends arrays in various .eslintrc.json files and adding or standardizing the eslint-plugin-storybook dependency to ~0.11.6 in corresponding package.json files.

Changes

Cohort / File(s)	Summary
ESLint Config Files apps/meteor/.eslintrc.json, ee/packages/pdf-worker/.eslintrc.json, packages/livechat/.eslintrc.json, packages/ui-composer/.eslintrc.json, packages/ui-video-conf/.eslintrc.json, packages/ui-voip/.eslintrc.json, packages/web-ui-registration/.eslintrc.json	Added "plugin:storybook/recommended" to extends array
Package Dependencies - New Additions apps/meteor/package.json, packages/fuselage-ui-kit/package.json, packages/livechat/package.json, packages/web-ui-registration/package.json	Added eslint-plugin-storybook (~0.11.6) as devDependency
Package Dependencies - Version Standardization packages/gazzodown/package.json, packages/ui-composer/package.json, packages/ui-voip/package.json	Updated eslint-plugin-storybook version from ^0.11.6 to ~0.11.6
Package Dependencies - Dual Addition ee/packages/pdf-worker/package.json	Added eslint-plugin-storybook (~0.11.6) to both dependencies and devDependencies

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• All changes follow an identical pattern across multiple packages with no variation in logic or structure
• Changes are purely configuration and dependency management with no runtime implications

Possibly related PRs

• chore(ui-video-conf): Review build configuration #37586: Modifies packages/ui-video-conf ESLint and Storybook plugin configuration with compiler changes
• chore(web-ui-registration): Review build configuration #37584: Modifies packages/web-ui-registration Storybook configuration, Babel/TS build settings, and dependencies
• chore(ui-composer): Review build configuration #37599: Modifies packages/ui-composer ESLint extends array for Storybook-related rules

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• ggazzo
• d-gubert

Poem

🐰 Hops through configs with glee,
Storybook rules aligned to be,
Tilde versioning so neat,
Consistency's sweet treat! 📚✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: applying eslint-plugin-storybook consistently across packages, matching the PR objectives.
Linked Issues check	✅ Passed	The PR successfully applies eslint-plugin-storybook consistently across all affected packages, including ESLint config updates and dependency additions ARCH-1890.
Out of Scope Changes check	✅ Passed	All changes are in-scope: the PR only updates ESLint configurations and adds/updates eslint-plugin-storybook dependencies across multiple packages.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/eslint-plugin-storybook

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c77a05b and b08cf4c.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (15)

• apps/meteor/.eslintrc.json (1 hunks)
• apps/meteor/package.json (1 hunks)
• ee/packages/pdf-worker/.eslintrc.json (1 hunks)
• ee/packages/pdf-worker/package.json (1 hunks)
• packages/fuselage-ui-kit/package.json (1 hunks)
• packages/gazzodown/package.json (1 hunks)
• packages/livechat/.eslintrc.json (1 hunks)
• packages/livechat/package.json (1 hunks)
• packages/ui-composer/.eslintrc.json (1 hunks)
• packages/ui-composer/package.json (1 hunks)
• packages/ui-video-conf/.eslintrc.json (1 hunks)
• packages/ui-voip/.eslintrc.json (1 hunks)
• packages/ui-voip/package.json (1 hunks)
• packages/web-ui-registration/.eslintrc.json (1 hunks)
• packages/web-ui-registration/package.json (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-11-24T17:08:17.039Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.039Z
Learning: Applies to **/*.{ts,tsx,js} : Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests

Applied to files:

• ee/packages/pdf-worker/.eslintrc.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: 📦 Build Packages
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

🔇 Additional comments (15)

packages/gazzodown/package.json (1)

68-68: No action required—ESLint configuration properly updated.

The package.json change correctly updates the version specifier from caret to tilde, and verification confirms the corresponding ESLint configuration file has been updated to extend "plugin:storybook/recommended".

packages/web-ui-registration/package.json (1)

51-51: LGTM.

The addition is consistent with the PR pattern and properly versioned.

packages/ui-voip/package.json (1)

65-65: Verify version constraint consistency across all packages.

This file changes from caret (^0.11.6) to tilde (~0.11.6), while other packages (meteor, web-ui-registration, livechat) have the tilde added directly. Confirm that the version specifier strategy is intentional and consistent across the entire PR.

packages/ui-voip/.eslintrc.json (1)

2-2: LGTM.

The "plugin:storybook/recommended" configuration is correctly appended to the extends array and pairs with the devDependency update in package.json.

packages/ui-composer/package.json (1)

46-46: Version consistency flagged in prior file.

This follows the same caret-to-tilde pattern as ui-voip. Refer to the verification request in that file regarding intentionality of this constraint change.

packages/livechat/.eslintrc.json (1)

2-2: LGTM.

The "plugin:storybook/recommended" configuration is correctly appended and pairs with the devDependency update in package.json (line 62).

packages/livechat/package.json (1)

62-62: LGTM.

The devDependency is correctly added with consistent tilde constraint and properly positioned among other eslint plugins.

ee/packages/pdf-worker/.eslintrc.json (1)

2-2: No issues found — eslint-plugin-storybook is properly declared.

Verification confirms that ee/packages/pdf-worker/package.json includes "eslint-plugin-storybook": "~0.11.6" in devDependencies. The .eslintrc.json configuration is correct and will resolve the plugin without errors.

apps/meteor/package.json (1)

182-182: eslint-plugin-storybook 0.11.6 is compatible with Storybook 8.6.14.

The devDependency addition is correctly positioned with a standard tilde constraint matching other eslint plugins in the file. Verification confirms version 0.11.6 is fully compatible with the declared Storybook 8.6.14.

packages/fuselage-ui-kit/package.json (1)

84-84: Dependency placement and version look good; verify corresponding ESLint config exists.

The devDependency for eslint-plugin-storybook ~0.11.6 is correctly placed and follows semantic versioning best practices. Confirm that packages/fuselage-ui-kit/.eslintrc.json includes "plugin:storybook/recommended" in its extends array to activate these linting rules.

ee/packages/pdf-worker/package.json (1)

46-46: ✅ Correct placement of eslint plugin dependency.

The eslint-plugin-storybook dependency is correctly placed in devDependencies alongside eslint, and aligns with the Storybook documentation for adding "plugin:storybook/recommended" to ESLint configuration.

packages/web-ui-registration/.eslintrc.json (1)

2-2: ESLint config properly extended with Storybook recommendations.

Adding "plugin:storybook/recommended" to the extends section is the correct pattern for enabling Storybook ESLint rules. The plugin is positioned as the last item in the extends array, allowing it to complement existing configurations. Verify that the corresponding packages/web-ui-registration/package.json includes the eslint-plugin-storybook ~0.11.6 devDependency.

packages/ui-video-conf/.eslintrc.json (1)

2-2: ESLint config properly extended with Storybook recommendations.

Adding "plugin:storybook/recommended" to the extends section follows Storybook best practices. The configuration is correctly positioned and consistent with other packages in this PR. Verify that the corresponding packages/ui-video-conf/package.json includes the eslint-plugin-storybook ~0.11.6 devDependency.

packages/ui-composer/.eslintrc.json (1)

2-2: ESLint config properly extended with Storybook recommendations.

Configuration change is consistent with other packages in this PR and aligns with Storybook documentation for adding "plugin:storybook/recommended" to the extends section of ESLint configuration. Verify that packages/ui-composer/package.json includes the eslint-plugin-storybook ~0.11.6 devDependency.

apps/meteor/.eslintrc.json (1)

2-2: ESLint config extended with Storybook plugin; verify corresponding package.json dependency.

Adding "plugin:storybook/recommended" to the extends section is the correct approach. The plugin is properly positioned as the last extend item, complementing existing configurations and story-specific overrides defined in lines 118–130. ⚠️ Critically important: Verify that apps/meteor/package.json includes eslint-plugin-storybook ~0.11.6 in devDependencies—this is the main application package and it's not provided in the review files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change	Percent
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	346MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	+213B
queue-worker-service	132MiB	132MiB	-138B
ddp-streamer-service	127MiB	127MiB	-164B
account-service	114MiB	114MiB	-370B
stream-hub-service	111MiB	111MiB	-404B
authorization-service	111MiB	111MiB	-305B
presence-service	111MiB	111MiB	+45B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/24 21:10 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Loading

Statistics (last 7 days):

• 📊 Average: 1.5GiB
• ⬇️ Minimum: 1.2GiB
• ⬆️ Maximum: 1.6GiB
• 🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

• Tag: pr-37602
• Baseline: develop
• Timestamp: 2025-11-24 21:10:02 UTC
• Historical data points: 7

---

Updated: Mon, 24 Nov 2025 21:10:02 GMT

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.83%. Comparing base (c77a05b) to head (b08cf4c).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37602      +/-   ##
===========================================
- Coverage    68.83%   68.83%   -0.01%     
===========================================
  Files         3361     3361              
  Lines       114341   114341              
  Branches     20619    20619              
===========================================
- Hits         78707    78703       -4     
+ Misses       33541    33539       -2     
- Partials      2093     2099       +6     

Flag	Coverage Δ
e2e	57.32% <ø> (-0.03%)	⬇️
e2e-api	42.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.