fix: users.update API call erases other customFields #36578

cardoso · 2025-07-30T21:09:52Z

Proposed changes (including videos or screenshots)

This PR fixes a bug where the /api/v1/users.update API call was replacing the entire customFields object instead of merging only the specified properties. The fix ensures that when updating custom fields, existing values are preserved while only specified fields are updated or added.

Key changes:

Modified the custom fields saving logic to use field-specific updates instead of replacing the entire object
Added comprehensive test coverage for both API endpoints and UI interactions
Updated the field-saving function to filter out undefined values and use MongoDB's dot notation for field updates

Show a summary per file

File	Description
`apps/meteor/app/lib/server/functions/saveCustomFieldsWithoutValidation.ts`	Core fix - changes from replacing entire customFields object to updating individual fields using dot notation
`apps/meteor/tests/end-to-end/api/users.ts`	API test coverage for custom fields merging behavior
`apps/meteor/tests/e2e/admin-users-custom-fields.spec.ts`	End-to-end UI test coverage for admin user custom field management
`apps/meteor/tests/e2e/page-objects/fragments/admin-flextab-users.ts`	Page object updates to support custom field testing
`.changeset/wild-kiwis-cover.md`	Changeset documentation for the bug fix

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1260

Steps to test or reproduce

Further comments

dionisio-bot · 2025-07-30T21:09:56Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

…s-other-customfields

changeset-bot · 2025-07-30T21:11:04Z

🦋 Changeset detected

Latest commit: 81716b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/http-router	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch
@rocket.chat/omni-core-ee	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-07-30T21:16:46Z

PR Preview Action v1.6.2
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36578/
Built to branch `gh-pages` at 2025-08-02 16:11 UTC. Preview will be ready when the GitHub Pages deployment is complete.

codecov · 2025-07-30T21:17:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.68%. Comparing base (1142862) to head (81716b7).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #36578      +/-   ##
===========================================
- Coverage    65.69%   65.68%   -0.01%     
===========================================
  Files         3195     3195              
  Lines       106739   106739              
  Branches     20321    20370      +49     
===========================================
- Hits         70122    70114       -8     
- Misses       33979    33986       +7     
- Partials      2638     2639       +1

Flag	Coverage Δ
e2e	`56.96% <ø> (+0.02%)`	⬆️
unit	`71.25% <ø> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

test: api test update custom fields

Copilot

Pull Request Overview

This PR fixes a bug where the /api/v1/users.update API call was replacing the entire customFields object instead of merging only the specified properties. The fix ensures that when updating custom fields, existing values are preserved while only specified fields are updated or added.

Key changes:

Modified the custom fields saving logic to use field-specific updates instead of replacing the entire object
Added comprehensive test coverage for both API endpoints and UI interactions
Updated the field-saving function to filter out undefined values and use MongoDB's dot notation for field updates

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`apps/meteor/app/lib/server/functions/saveCustomFieldsWithoutValidation.ts`	Core fix - changes from replacing entire customFields object to updating individual fields using dot notation
`apps/meteor/tests/end-to-end/api/users.ts`	API test coverage for custom fields merging behavior
`apps/meteor/tests/e2e/admin-users-custom-fields.spec.ts`	End-to-end UI test coverage for admin user custom field management
`apps/meteor/tests/e2e/page-objects/fragments/admin-flextab-users.ts`	Page object updates to support custom field testing
`.changeset/wild-kiwis-cover.md`	Changeset documentation for the bug fix

apps/meteor/app/lib/server/functions/saveCustomFieldsWithoutValidation.ts

…s-other-customfields

pierre-lehnen-rc

Please include an additional test ensuring that if the admin removes a custom field's value (aka change it to an empty string), it gets successfully removed from the user too.

cardoso · 2025-08-04T14:04:22Z

/patch

dionisio-bot · 2025-08-04T14:04:44Z

Pull request #36612 added to Project: "Patch 7.9.1"

scuciatto · 2025-08-04T14:18:43Z

/backport 7.8.4

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

dionisio-bot · 2025-08-04T14:19:23Z

Pull request #36613 added to Project: "Patch 7.8.4"

scuciatto · 2025-08-04T14:43:20Z

/backport 7.7.8

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

dionisio-bot · 2025-08-04T14:44:01Z

Pull request #36614 added to Project: "Patch 7.7.8"

scuciatto · 2025-08-04T15:48:53Z

/backport 7.6.5

dionisio-bot · 2025-08-04T15:49:54Z

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.6.5-36578
git cherry-pick 57c6a3a1cf9c0cdc643bc955a3093948f42f01fc
// solve the conflict
git push

after that just run /backport 7.6.5 again

scuciatto · 2025-08-04T15:49:59Z

/backport 7.5.4

dionisio-bot · 2025-08-04T15:50:35Z

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.5.4-36578
git cherry-pick 57c6a3a1cf9c0cdc643bc955a3093948f42f01fc
// solve the conflict
git push

after that just run /backport 7.5.4 again

scuciatto · 2025-08-04T15:51:40Z

/backport 7.4.5

dionisio-bot · 2025-08-04T15:52:15Z

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.4.5-36578
git cherry-pick 57c6a3a1cf9c0cdc643bc955a3093948f42f01fc
// solve the conflict
git push

after that just run /backport 7.4.5 again

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

cardoso · 2025-08-04T16:29:34Z

/backport 7.6.5

dionisio-bot · 2025-08-04T16:29:52Z

Pull request #36615 added to Project: "Patch 7.6.5"

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

cardoso · 2025-08-04T16:35:13Z

/backport 7.4.5

dionisio-bot · 2025-08-04T16:35:31Z

Pull request #36616 added to Project: "Patch 7.4.5"

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

cardoso · 2025-08-04T16:37:03Z

/backport 7.5.4

dionisio-bot · 2025-08-04T16:37:24Z

Pull request #36618 added to Project: "Patch 7.5.4"

jessicaschelly and others added 8 commits July 30, 2025 14:05

test: api test update custom fields

6807cf4

Merge branch 'develop' into test/api-custom-fields

35f017e

Merge branch 'develop' into test/api-custom-fields

93ffc02

test: add tests for UI admin custom fields

b35d8e2

improve user creation

30bbc27

fix locators

2e71368

remove length restrictions

c2f60f6

fix: users.update API call erases other customFields

71a1c48

cardoso marked this pull request as draft July 30, 2025 21:10

Merge branch 'develop' into fix/CORE-1260-users-update-api-call-erase…

7fd3bf4

…s-other-customfields

cardoso added this to the 7.10.0 milestone Jul 30, 2025

cardoso added 2 commits July 30, 2025 18:28

Merge pull request #36576 from RocketChat/test/api-custom-fields

486e6c7

test: api test update custom fields

Create wild-kiwis-cover.md

b46dc17

cardoso requested a review from Copilot July 31, 2025 12:28

Copilot AI reviewed Jul 31, 2025

View reviewed changes

apps/meteor/app/lib/server/functions/saveCustomFieldsWithoutValidation.ts Show resolved Hide resolved

cardoso marked this pull request as ready for review July 31, 2025 12:31

cardoso requested review from a team as code owners July 31, 2025 12:31

cardoso added 5 commits July 31, 2025 09:31

Merge branch 'develop' into fix/CORE-1260-users-update-api-call-erase…

ea40aca

…s-other-customfields

Update wild-kiwis-cover.md

bb93bbb

fix: possible issue with falsy values

723f5e1

Merge branch 'develop' into fix/CORE-1260-users-update-api-call-erase…

2a1127c

…s-other-customfields

Merge branch 'develop' into fix/CORE-1260-users-update-api-call-erase…

54a1a05

…s-other-customfields

pierre-lehnen-rc previously requested changes Jul 31, 2025

View reviewed changes

test: empty string

3527a30

cardoso requested a review from pierre-lehnen-rc July 31, 2025 18:27

dionisio-bot bot mentioned this pull request Aug 4, 2025

fix: users.update API call erases other customFields #36612

Merged

dionisio-bot bot pushed a commit that referenced this pull request Aug 4, 2025

fix: users.update API call erases other customFields (#36578)

de91b7e

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

dionisio-bot bot mentioned this pull request Aug 4, 2025

fix: users.update API call erases other customFields #36613

Merged

dionisio-bot bot pushed a commit that referenced this pull request Aug 4, 2025

fix: users.update API call erases other customFields (#36578)

6f50b16

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

dionisio-bot bot mentioned this pull request Aug 4, 2025

fix: users.update API call erases other customFields #36614

Merged

cardoso added a commit that referenced this pull request Aug 4, 2025

fix: users.update API call erases other customFields (#36578)

3834425

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

dionisio-bot bot mentioned this pull request Aug 4, 2025

fix: users.update API call erases other customFields #36615

Merged

cardoso added a commit that referenced this pull request Aug 4, 2025

fix: users.update API call erases other customFields (#36578)

8395787

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

dionisio-bot bot mentioned this pull request Aug 4, 2025

fix: users.update API call erases other customFields #36616

Merged

cardoso added a commit that referenced this pull request Aug 4, 2025

fix: users.update API call erases other customFields (#36578)

a6c6a17

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>

dionisio-bot bot mentioned this pull request Aug 4, 2025

fix: users.update API call erases other customFields #36618

Merged

rocketchat-github-ci mentioned this pull request Aug 20, 2025

Release 7.10.0 #36760

Merged

fix: users.update API call erases other customFields #36578

fix: users.update API call erases other customFields #36578

Uh oh!

Conversation

cardoso commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-08-02 16:11 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

pierre-lehnen-rc left a comment

Choose a reason for hiding this comment

Uh oh!

cardoso commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

scuciatto commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

scuciatto commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

scuciatto commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

scuciatto commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

scuciatto commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

cardoso commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

cardoso commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

cardoso commented Aug 4, 2025

Uh oh!

dionisio-bot bot commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cardoso commented Jul 30, 2025 •

edited

Loading

dionisio-bot bot commented Jul 30, 2025 •

edited

Loading

changeset-bot bot commented Jul 30, 2025 •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-08-02 16:11 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

codecov bot commented Jul 30, 2025 •

edited

Loading