fix: users.update API call erases other customFields #36612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>
🦋 Changeset detectedLatest commit: 8ad8868 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.9.1 #36612 +/- ##
=================================================
+ Coverage 65.71% 65.72% +0.01%
=================================================
Files 3172 3172
Lines 105574 105574
Branches 20027 20032 +5
=================================================
+ Hits 69376 69393 +17
+ Misses 33527 33512 -15
+ Partials 2671 2669 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
cardoso
approved these changes
Aug 4, 2025
Member
cardoso
left a comment
cardoso
left a comment
There was a problem hiding this comment.
Seems all tests are passing. Just a known flaky failed. Triggered a re-run.
1) tests/e2e/e2e-encryption.spec.ts:93:6 › initial setup › expect to manually set a new password ─
Test timeout of 60000ms exceeded.
Error: locator.fill: Target page, context or browser has been closed
Call log:
- waiting for getByRole('dialog', { name: 'Enter E2EE password' }).getByPlaceholder('Please enter your E2EE password')
- locator resolved to <input size="1" value="" type="password" placeholder="Please enter your E2EE password" class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box--type-password rcx-input-box"/>
- fill("077f6261-291a-4c33-a198-97bc47c37ee3")
- attempting fill action
- waiting for element to be visible, enabled and editable
- element was detached from the DOM, retrying
at page-objects/fragments/e2ee.ts:83
81 |
82 | async enterPassword(password: string) {
> 83 | await this.passwordInput.fill(password);
| ^
84 | await this.enterE2EEPasswordButton.click();
85 | await this.waitForDismissal();
86 | }
at EnterE2EEPasswordModal.enterPassword (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor/tests/e2e/page-objects/fragments/e2ee.ts:83:28)
at /home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor/tests/e2e/e2e-encryption.spec.ts:123:32
cardoso
added
stat: QA assured
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36578