Skip to content

Conversation

@dionisio-bot
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Aug 4, 2025

Backport of #36578

Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>
@dionisio-bot dionisio-bot bot requested review from a team as code owners August 4, 2025 16:37
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: 6188d5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot requested a review from cardoso August 4, 2025 16:37
@dionisio-bot
Copy link
Contributor Author

dionisio-bot bot commented Aug 4, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good if CI passes

cardoso
cardoso previously approved these changes Aug 4, 2025
Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggered a re-run due to likely unrelated failure in build packages:

error: Import 'https://deno.land/std@0.216.0/io/write_all.ts' failed: 502 Bad Gateway
    at file:///home/runner/work/Rocket.Chat/Rocket.Chat/packages/apps-engine/deno-runtime/lib/messenger.ts:1:26

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.63%. Comparing base (bceb033) to head (6188d5c).
⚠️ Report is 1 commits behind head on release-7.5.4.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.5.4   #36618   +/-   ##
==============================================
  Coverage          59.63%   59.63%           
==============================================
  Files               2832     2832           
  Lines              68942    68942           
  Branches           15290    15290           
==============================================
  Hits               41113    41113           
  Misses             25152    25152           
  Partials            2677     2677           
Flag Coverage Δ
unit 75.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36618/

Built to branch gh-pages at 2025-08-04 20:14 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add a missing test helper

cardoso
cardoso previously approved these changes Aug 4, 2025
Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-running failed checks due to SAML setup issue:

  1) saml.spec.ts:155:6 › SAML › Login 

    {
      exitCode: 1,
      err: 'time="2025-08-04T18:31:41Z" level=warning msg="/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor/tests/e2e/containers/saml/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion"\n' +
        'Dockerfile:4\n' +
        '--------------------\n' +
        '   3 |     # Utilities\n' +
        '   4 | >>> RUN apt-get update && \\\n' +
        '   5 | >>>     apt-get -y install apt-transport-https git curl vim --no-install-recommends && \\\n' +
        '   6 | >>>     rm -r /var/lib/apt/lists/*\n' +
        '   7 |     \n' +
        '--------------------\n' +
        'failed to solve: process "/bin/sh -c apt-get update &&     apt-get -y install apt-transport-https git curl vim --no-install-recommends &&     rm -r /var/lib/apt/lists/*" did not complete successfully: exit code: 100\n',

Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated SAML dockerfile

@cardoso cardoso added the stat: QA assured Means it has been tested and approved by a company insider label Aug 4, 2025
@ggazzo ggazzo merged commit 17933e8 into release-7.5.4 Aug 5, 2025
49 checks passed
@ggazzo ggazzo deleted the backport-7.5.4-36578 branch August 5, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants