-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: users.update API call erases other customFields #36618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Jessica Schelly Souza <jessica_schelly@hotmail.com>
🦋 Changeset detectedLatest commit: 6188d5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
cardoso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good if CI passes
cardoso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triggered a re-run due to likely unrelated failure in build packages:
error: Import 'https://deno.land/std@0.216.0/io/write_all.ts' failed: 502 Bad Gateway
at file:///home/runner/work/Rocket.Chat/Rocket.Chat/packages/apps-engine/deno-runtime/lib/messenger.ts:1:26
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.5.4 #36618 +/- ##
==============================================
Coverage 59.63% 59.63%
==============================================
Files 2832 2832
Lines 68942 68942
Branches 15290 15290
==============================================
Hits 41113 41113
Misses 25152 25152
Partials 2677 2677
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
cardoso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to add a missing test helper
cardoso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-running failed checks due to SAML setup issue:
1) saml.spec.ts:155:6 › SAML › Login
{
exitCode: 1,
err: 'time="2025-08-04T18:31:41Z" level=warning msg="/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor/tests/e2e/containers/saml/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion"\n' +
'Dockerfile:4\n' +
'--------------------\n' +
' 3 | # Utilities\n' +
' 4 | >>> RUN apt-get update && \\\n' +
' 5 | >>> apt-get -y install apt-transport-https git curl vim --no-install-recommends && \\\n' +
' 6 | >>> rm -r /var/lib/apt/lists/*\n' +
' 7 | \n' +
'--------------------\n' +
'failed to solve: process "/bin/sh -c apt-get update && apt-get -y install apt-transport-https git curl vim --no-install-recommends && rm -r /var/lib/apt/lists/*" did not complete successfully: exit code: 100\n',
cardoso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated SAML dockerfile
Backport of #36578