test: add saml login tests for user without name and user with channels #36383

jessicaschelly · 2025-07-08T21:18:01Z

Proposed Changes

This PR adds end-to-end tests for two SAML authentication scenarios:

1. Login - User without name

Test Coverage: Validates name fallback behavior when SAML users is missing cn attribute or displayName
Two Scenarios Tested:
- When displayName is not provided in SAML response → User name falls back to username
- When displayName is provided in SAML response → User name uses the provided displayName
Test Users: samluser5 (no displayName) and samluser6 (with displayName)

2. Login - User with channels attribute

Test Coverage: Validates SAML channels attribute functionality for automatic channel management
Features Tested:
- Automatic channel creation based on SAML attributes
- User membership assignment to existing channels
- User membership assignment to auto-created channels
Configuration: Enables SAML_Custom_Default_channels_update setting
Test User: samluser7 with channels attribute containing saml-channel-1 and saml-channel-2

Issue(s)

https://rocketchat.atlassian.net/browse/QA-86

dionisio-bot · 2025-07-08T21:18:06Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-07-08T21:18:07Z

⚠️ No Changeset found

Latest commit: 5f12982

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-07-08T21:22:42Z

PR Preview Action v1.6.2
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36383/
Built to branch `gh-pages` at 2025-08-13 20:32 UTC. Preview will be ready when the GitHub Pages deployment is complete.

codecov · 2025-07-08T21:23:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.79%. Comparing base (8f62a39) to head (5f12982).
⚠️ Report is 27 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #36383    +/-   ##
=========================================
  Coverage    65.79%   65.79%            
=========================================
  Files         3233     3234     +1     
  Lines       108113   108095    -18     
  Branches     20575    20697   +122     
=========================================
- Hits         71131    71124     -7     
+ Misses       34322    34307    -15     
- Partials      2660     2664     +4

Flag	Coverage Δ
e2e	`57.14% <ø> (+<0.01%)`	⬆️
unit	`71.24% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

apps/meteor/tests/e2e/saml.spec.ts

rebuild yarn.lock clone and build homeserver repo indentatioin change setup-node order remove existing homeserver path test /tmp diff job :/ must link use bundle branch fix storybook too fix lint error fix old federation tests fix more similar issues ci: remove deploy-preview for PRs (#36725) test: cleanup page-objects (#36665) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> regression: Prevent `load more` in emoji picker route to home page (#36720) fix: unhandled rejection from stale runtime (#36670) fix: prevent unexpected token errors from newer syntax in apps (#36625) chore: Move E2E Encryption startup (#36722) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> fix: `VideoConfPopup` not receiving focus properly (#36738) i18n: Incomplete Room Name Validation Message (#35318) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> fix: encryption toggle disabled/reset when toggling Private or Broadcast under E2E defaults (#36714) fix: moment js not loading some locales (#36651) fix: Custom notification sounds on incoming messages (#36703) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> fix: `onlyMyDepartments` not applying to agents (#36747) fix: enhance inquiry locking mechanism with timeout and error handling (#36749) fix: media playback failing due to expired urls (#36622) test: add saml login tests for user without name and user with channels (#36383) more fixes remove homeserver link again more lint issues another coupe cache homeserver stuff another lint probelem yeah i ran lint locally finally. fix the other dockerfiles

rebuild yarn.lock clone and build homeserver repo indentatioin change setup-node order remove existing homeserver path test /tmp diff job :/ must link use bundle branch fix storybook too fix lint error fix old federation tests fix more similar issues ci: remove deploy-preview for PRs (#36725) test: cleanup page-objects (#36665) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> regression: Prevent in emoji picker route to home page (#36720) fix: unhandled rejection from stale runtime (#36670) fix: prevent unexpected token errors from newer syntax in apps (#36625) chore: Move E2E Encryption startup (#36722) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> fix: not receiving focus properly (#36738) i18n: Incomplete Room Name Validation Message (#35318) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> fix: encryption toggle disabled/reset when toggling Private or Broadcast under E2E defaults (#36714) fix: moment js not loading some locales (#36651) fix: Custom notification sounds on incoming messages (#36703) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> fix: not applying to agents (#36747) fix: enhance inquiry locking mechanism with timeout and error handling (#36749) fix: media playback failing due to expired urls (#36622) test: add saml login tests for user without name and user with channels (#36383) more fixes remove homeserver link again more lint issues another coupe cache homeserver stuff another lint probelem yeah i ran lint locally finally. fix the other dockerfiles

test: add SAML login tests for user without name and user with channels

0df06dd

jessicaschelly added 2 commits July 9, 2025 15:44

improve tests

445a725

add test for fallback to displayname

3debf83

jessicaschelly changed the title ~~test: add SAML login tests for user without name and user with channels~~ test: add saml login tests for user without name and user with channels Jul 10, 2025

Merge branch 'develop' into test/saml-tests

ed78d8a

jessicaschelly marked this pull request as ready for review July 10, 2025 16:24

jessicaschelly requested a review from a team as a code owner July 10, 2025 16:24

jessicaschelly requested a review from pierre-lehnen-rc July 10, 2025 16:25

add promise all and user order

7f74cd3

pierre-lehnen-rc reviewed Jul 10, 2025

View reviewed changes

apps/meteor/tests/e2e/saml.spec.ts Show resolved Hide resolved

jessicaschelly added 2 commits July 17, 2025 13:39

add test for user without channel attribute

098a184

Merge branch 'develop' into test/saml-tests

564e0d6

jessicaschelly requested a review from pierre-lehnen-rc July 17, 2025 17:50

scuciatto added this to the 7.10.0 milestone Jul 22, 2025

jessicaschelly added 2 commits August 13, 2025 17:22

Merge branch 'develop' into test/saml-tests

c24a0ee

fix lint

5f12982

pierre-lehnen-rc approved these changes Aug 13, 2025

View reviewed changes

ggazzo merged commit ae6b57a into develop Aug 20, 2025
49 checks passed

ggazzo deleted the test/saml-tests branch August 20, 2025 04:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add saml login tests for user without name and user with channels #36383

test: add saml login tests for user without name and user with channels #36383

Uh oh!

jessicaschelly commented Jul 8, 2025 •

edited

Loading

Uh oh!

dionisio-bot bot commented Jul 8, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 8, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-08-13 20:32 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented Jul 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

test: add saml login tests for user without name and user with channels #36383

test: add saml login tests for user without name and user with channels #36383

Uh oh!

Conversation

jessicaschelly commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

1. Login - User without name

2. Login - User with channels attribute

Issue(s)

Uh oh!

dionisio-bot bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-08-13 20:32 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

codecov bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jessicaschelly commented Jul 8, 2025 •

edited

Loading

dionisio-bot bot commented Jul 8, 2025 •

edited

Loading

changeset-bot bot commented Jul 8, 2025 •

edited

Loading

github-actions bot commented Jul 8, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-08-13 20:32 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

codecov bot commented Jul 8, 2025 •

edited

Loading