Skip to content

feat: Bubble on new messages indicators - #31478

Merged
ggazzo merged 8 commits into
developfrom
feat/bubble
Jan 18, 2024
Merged

feat: Bubble on new messages indicators#31478
ggazzo merged 8 commits into
developfrom
feat/bubble

Conversation

@juliajforesti

@juliajforesti juliajforesti commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

DSAR-431

Proposed changes (including videos or screenshots)

image

Issue(s)

Steps to test or reproduce

Further comments

@juliajforesti juliajforesti added this to the 6.6 milestone Jan 17, 2024
@changeset-bot

changeset-bot Bot commented Jan 17, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 98750b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jan 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (44be98d) 49.57% compared to head (98750b5) 49.56%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31478      +/-   ##
===========================================
- Coverage    49.57%   49.56%   -0.02%     
===========================================
  Files         3316     3316              
  Lines        81542    81541       -1     
  Branches     16722    16721       -1     
===========================================
- Hits         40425    40413      -12     
- Misses       36414    36420       +6     
- Partials      4703     4708       +5     
Flag Coverage Δ
e2e 53.13% <42.85%> (-0.05%) ⬇️
e2e-api 40.69% <ø> (ø)
unit 76.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti
juliajforesti marked this pull request as ready for review January 17, 2024 22:02
@juliajforesti
juliajforesti requested review from a team as code owners January 17, 2024 22:02
@ggazzo
ggazzo merged commit 0ed84cb into develop Jan 18, 2024
@ggazzo
ggazzo deleted the feat/bubble branch January 18, 2024 15:05
gabriellsh added a commit that referenced this pull request Jan 18, 2024
…dk/webdav

* 'sdk/webdav' of github.com:RocketChat/Rocket.Chat:
  feat: `Bubble` on new messages indicators (#31478)
  test: fix flaky setGuestName test (#31486)
gabriellsh added a commit that referenced this pull request Jan 19, 2024
…/emailEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (166 commits)
  feat: Add `chat.getURLPreview` endpoint (#30478)
  chore: QoL changes for Omnichannel (#31468)
  fix: add missing labels to UsersByTimeOfTheDaySection (#31368)
  refactor: Remove `Notifications` module (#31463)
  i18n: zh translation error (#21600)
  feat: `Bubble` on new messages indicators (#31478)
  test: fix flaky setGuestName test (#31486)
  Release 6.5.3
  chore: RateLimiter to async (#31480)
  chore: Revert "chore: Add missing changeset file" (#31481)
  chore: Remove `MessageContentBody` additional styles (#31476)
  chore: Replace `Notifications` module in favor of `SDK` inside CachedCollection (#31424)
  chore: improve backend startup (#31479)
  chore: fix embedded livechat tests (#31477)
  fix: Department name being double escaped (#31454)
  chore: Remove unnecessary changeset file (#31472)
  chore(eslint-config): Include missing ESLint configuration for React (#30977)
  refactor: Replace `Notifications` module in favor of `sdk` for Omnichannel/WebRTC (#31460)
  refactor: Replace `Notifications` module in favor of `sdk` for Video Conf (#31462)
  feat: Add support to cancel editing message action (#31347)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants