Skip to content

chore: QoL changes for Omnichannel - #31468

Merged
kodiakhq[bot] merged 10 commits into
developfrom
chore/perf-bh
Jan 19, 2024
Merged

chore: QoL changes for Omnichannel#31468
kodiakhq[bot] merged 10 commits into
developfrom
chore/perf-bh

Conversation

@KevLehman

@KevLehman KevLehman commented Jan 17, 2024

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

  • More projections, so less data fetched from mongo
  • Changed the logic of BH from one agg to check if a user was an agent on department to one single aggregation for all users
  • Changed the logic of BH from one query to check if a user was without a department to one single query for all users
  • Removed unnecessary checks on livechat/department and do all in one single call
  • Updated callback types & removed anys

@changeset-bot

changeset-bot Bot commented Jan 17, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c9b31d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (75d235a) 49.55% compared to head (c9b31d7) 49.54%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31468      +/-   ##
===========================================
- Coverage    49.55%   49.54%   -0.02%     
===========================================
  Files         3313     3311       -2     
  Lines        81476    81470       -6     
  Branches     16710    16706       -4     
===========================================
- Hits         40378    40364      -14     
- Misses       36392    36404      +12     
+ Partials      4706     4702       -4     
Flag Coverage Δ
e2e 53.15% <ø> (-0.01%) ⬇️
e2e-api 40.66% <61.90%> (-0.02%) ⬇️
unit 76.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Comment thread apps/meteor/ee/app/livechat-enterprise/server/business-hour/Multiple.ts Outdated
@KevLehman KevLehman changed the title chore: test chore: QoL changes for Omnichannel Jan 17, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 17, 2024
Comment thread apps/meteor/app/livechat/server/business-hour/AbstractBusinessHour.ts Outdated
Comment thread apps/meteor/ee/server/models/raw/LivechatDepartment.ts Outdated
Comment thread apps/meteor/tests/end-to-end/api/livechat/04-dashboards.ts
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 18, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 18, 2024
@KevLehman
KevLehman marked this pull request as ready for review January 19, 2024 13:58
@KevLehman
KevLehman requested review from a team as code owners January 19, 2024 13:58
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 19, 2024
@kodiakhq
kodiakhq Bot merged commit 6ca6871 into develop Jan 19, 2024
@kodiakhq
kodiakhq Bot deleted the chore/perf-bh branch January 19, 2024 15:45
gabriellsh added a commit that referenced this pull request Jan 19, 2024
…/emailEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (166 commits)
  feat: Add `chat.getURLPreview` endpoint (#30478)
  chore: QoL changes for Omnichannel (#31468)
  fix: add missing labels to UsersByTimeOfTheDaySection (#31368)
  refactor: Remove `Notifications` module (#31463)
  i18n: zh translation error (#21600)
  feat: `Bubble` on new messages indicators (#31478)
  test: fix flaky setGuestName test (#31486)
  Release 6.5.3
  chore: RateLimiter to async (#31480)
  chore: Revert "chore: Add missing changeset file" (#31481)
  chore: Remove `MessageContentBody` additional styles (#31476)
  chore: Replace `Notifications` module in favor of `SDK` inside CachedCollection (#31424)
  chore: improve backend startup (#31479)
  chore: fix embedded livechat tests (#31477)
  fix: Department name being double escaped (#31454)
  chore: Remove unnecessary changeset file (#31472)
  chore(eslint-config): Include missing ESLint configuration for React (#30977)
  refactor: Replace `Notifications` module in favor of `sdk` for Omnichannel/WebRTC (#31460)
  refactor: Replace `Notifications` module in favor of `sdk` for Video Conf (#31462)
  feat: Add support to cancel editing message action (#31347)
  ...
@casalsgh casalsgh added this to the 6.6 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants