Skip to content

fix: Department name being double escaped - #31454

Merged
kodiakhq[bot] merged 4 commits into
developfrom
fix/departmnt-doble-escape
Jan 17, 2024
Merged

fix: Department name being double escaped#31454
kodiakhq[bot] merged 4 commits into
developfrom
fix/departmnt-doble-escape

Conversation

@KevLehman

@KevLehman KevLehman commented Jan 15, 2024

Copy link
Copy Markdown
Member

SUP-460

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Jan 15, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0862556

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/livechat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jan 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e889952) 59.84% compared to head (0862556) 49.56%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31454       +/-   ##
============================================
- Coverage    59.84%   49.56%   -10.28%     
============================================
  Files         1794     3313     +1519     
  Lines        34937    81480    +46543     
  Branches      7271    16711     +9440     
============================================
+ Hits         20907    40389    +19482     
- Misses       12429    36392    +23963     
- Partials      1601     4699     +3098     
Flag Coverage Δ
e2e 53.17% <ø> (+<0.01%) ⬆️
e2e-api 40.69% <ø> (?)
unit 76.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 17, 2024
@KevLehman
KevLehman marked this pull request as ready for review January 17, 2024 19:49
@KevLehman
KevLehman requested review from a team as code owners January 17, 2024 19:49
@KevLehman KevLehman added this to the 6.6 milestone Jan 17, 2024
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 17, 2024
@kodiakhq
kodiakhq Bot merged commit bc28633 into develop Jan 17, 2024
@kodiakhq
kodiakhq Bot deleted the fix/departmnt-doble-escape branch January 17, 2024 20:57
gabriellsh added a commit that referenced this pull request Jan 19, 2024
…/emailEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (166 commits)
  feat: Add `chat.getURLPreview` endpoint (#30478)
  chore: QoL changes for Omnichannel (#31468)
  fix: add missing labels to UsersByTimeOfTheDaySection (#31368)
  refactor: Remove `Notifications` module (#31463)
  i18n: zh translation error (#21600)
  feat: `Bubble` on new messages indicators (#31478)
  test: fix flaky setGuestName test (#31486)
  Release 6.5.3
  chore: RateLimiter to async (#31480)
  chore: Revert "chore: Add missing changeset file" (#31481)
  chore: Remove `MessageContentBody` additional styles (#31476)
  chore: Replace `Notifications` module in favor of `SDK` inside CachedCollection (#31424)
  chore: improve backend startup (#31479)
  chore: fix embedded livechat tests (#31477)
  fix: Department name being double escaped (#31454)
  chore: Remove unnecessary changeset file (#31472)
  chore(eslint-config): Include missing ESLint configuration for React (#30977)
  refactor: Replace `Notifications` module in favor of `sdk` for Omnichannel/WebRTC (#31460)
  refactor: Replace `Notifications` module in favor of `sdk` for Video Conf (#31462)
  feat: Add support to cancel editing message action (#31347)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants