fix: Language selection box is empty which should be default - #31312
Merged
Conversation
🦋 Changeset detectedLatest commit: ed0f522 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougfabris
previously approved these changes
Dec 26, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31312 +/- ##
===========================================
- Coverage 49.33% 49.30% -0.03%
===========================================
Files 3299 3299
Lines 81122 81122
Branches 16594 16594
===========================================
- Hits 40020 40000 -20
- Misses 36454 36462 +8
- Partials 4648 4660 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
Bot
added
stat: ready to merge
dougfabris
approved these changes
Dec 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
BEFORE THE FIX
https://github.com/RocketChat/Rocket.Chat/assets/112304873/0fdc1b0f-4e42-4546-87b8-3968e56e1c9c
AFTER THE FIX
https://github.com/RocketChat/Rocket.Chat/assets/112304873/ca4c6cc2-f121-4561-a6ff-5ba1d93a819f
REASON BEHIND CHANGES
The type of 'language' field in default values was string | undefined. When undefined it wont show anything, so we need to use correct type for 'language' which is only 'string' and also if language is undefined(when useUserPreference returns undefiend) we should assign it with blank ''
Issue(s)
This should close issues :-
fix #31307
Steps to test or reproduce
Further comments