Skip to content

fix: Change language to default when no value is provided in Preferences in Localization section - #31311

Closed
mayank6725 wants to merge 2 commits into
RocketChat:developfrom
mayank6725:fix/changing-default-language-in-localization-to-default
Closed

fix: Change language to default when no value is provided in Preferences in Localization section#31311
mayank6725 wants to merge 2 commits into
RocketChat:developfrom
mayank6725:fix/changing-default-language-in-localization-to-default

Conversation

@mayank6725

@mayank6725 mayank6725 commented Dec 23, 2023

Copy link
Copy Markdown
Contributor

Fixes #31307

What was done to fix this?

Just added the default value to be '' for value field in PreferencesLocalizationSection.tsx when no language is provided.
'' is the default key value for language Default

Before

image

After

image

@mayank6725
mayank6725 requested a review from a team as a code owner December 23, 2023 11:03
@changeset-bot

changeset-bot Bot commented Dec 23, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1022fc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mayank6725 mayank6725 changed the title Change language to default when no value is provided fix: Change language to default when no value is provided in Preferences in Localization section Dec 23, 2023
@codecov

codecov Bot commented Dec 23, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (caa7707) 49.33% compared to head (1022fc1) 76.39%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31311       +/-   ##
============================================
+ Coverage    49.33%   76.39%   +27.06%     
============================================
  Files         3299      281     -3018     
  Lines        81122     8972    -72150     
  Branches     16594     1697    -14897     
============================================
- Hits         40020     6854    -33166     
+ Misses       36454     1693    -34761     
+ Partials      4648      425     -4223     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 76.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris

Copy link
Copy Markdown
Member

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's duplicated now and it has been fixed in another one. #31312


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

@dougfabris dougfabris closed this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language selection box is empty which should be default

3 participants