Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 2, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

⚠️ No Changeset found

Latest commit: cd8d70d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the chore/callcacks-async branch from 2115760 to 72064b1 Compare October 2, 2023 15:07
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #30547 (cd8d70d) into develop (aa30c85) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30547      +/-   ##
===========================================
- Coverage    50.93%   50.93%   -0.01%     
===========================================
  Files          809      803       -6     
  Lines        15016    14995      -21     
  Branches      2724     2720       -4     
===========================================
- Hits          7649     7637      -12     
+ Misses        6958     6936      -22     
- Partials       409      422      +13     
Flag Coverage Δ
e2e 48.62% <ø> (+0.04%) ⬆️
unit 62.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/callcacks-async branch from 72064b1 to 6a19b48 Compare October 2, 2023 17:51
@ggazzo ggazzo marked this pull request as ready for review October 2, 2023 17:56
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 2, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 2, 2023
@kodiakhq kodiakhq bot merged commit 6d4cb42 into develop Oct 2, 2023
@kodiakhq kodiakhq bot deleted the chore/callcacks-async branch October 2, 2023 22:00
gabriellsh added a commit that referenced this pull request Oct 3, 2023
…e/translationCdn

* 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits)
  chore: do not focus messagebox on mobile devices (#30553)
  chore: add the new endpoints to sync with cloud (#30546)
  fix: in forward search field, user cannot be found by name (Full Name) (#29663)
  chore: set license public key v3 with v2 (#30548)
  chore: adjust callbacks return type (#30547)
  chore: Delete Trigger Endpoint (#30533)
  test: adding missing verifications on message-actions (#30531)
  refactor: Oembed backend (#30228)
  test: refactor API E2E tests for groups endpoints (#30523)
  test: adding missing verifications on threads (#30528)
  chore: refactor cloud sync (#30401)
  refactor: Omni logs (#30322)
  refactor: Livechat Header -> ts (#30255)
  chore: Deprecate un-used meteor method for omnichannel analytics (#30421)
  feat: add supported versions + minimum clients versions to the info endpoint (#30178)
  feat: Auto-enable autotranslate (#30370)
  chore: Prevent call license and registration status endpoints when not enough permission (#30336)
  ci: Security/GitHub jira integration (#29776)
  feat: License V3 (#30287)
  chore: move Omnichannel toolbox section from sidebar room list (#30502)
  ...
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants