feat: License V3 #30287
Merged
feat: License V3 #30287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 79fe515 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30287 +/- ##
===========================================
+ Coverage 50.23% 50.74% +0.51%
===========================================
Files 780 801 +21
Lines 14475 14952 +477
Branches 2616 2721 +105
===========================================
+ Hits 7271 7587 +316
- Misses 6809 6945 +136
- Partials 395 420 +25
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
force-pushed
the
feat/nbj-295-license-v3-type
branch
from
ce9270b to
cb43adc
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+8
to
+9
| licenseURL = licenseURL | ||
| .replace(/\./g, '\\.') // convert dots to literal |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
ggazzo
force-pushed
the
feat/nbj-295-license-v3-type
branch
4 times, most recently
from
48d1071 to
ac3f4bc
Compare
ggazzo
reviewed
Sep 22, 2023
ee/packages/license/src/validation/getCurrentValueForLicenseLimit.ts
Outdated
Show resolved
Hide resolved
KevLehman
reviewed
Sep 27, 2023
ee/packages/license/src/validation/getCurrentValueForLicenseLimit.ts
Outdated
Show resolved
Hide resolved
debdutdeb
reviewed
Sep 27, 2023
ggazzo
force-pushed
the
feat/nbj-295-license-v3-type
branch
from
37d3e43 to
24062c3
Compare
ggazzo
approved these changes
Sep 28, 2023
ggazzo
force-pushed
the
feat/nbj-295-license-v3-type
branch
from
24062c3 to
79fe515
Compare
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 3, 2023
…e/translationCdn * 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits) chore: do not focus messagebox on mobile devices (#30553) chore: add the new endpoints to sync with cloud (#30546) fix: in forward search field, user cannot be found by name (Full Name) (#29663) chore: set license public key v3 with v2 (#30548) chore: adjust callbacks return type (#30547) chore: Delete Trigger Endpoint (#30533) test: adding missing verifications on message-actions (#30531) refactor: Oembed backend (#30228) test: refactor API E2E tests for groups endpoints (#30523) test: adding missing verifications on threads (#30528) chore: refactor cloud sync (#30401) refactor: Omni logs (#30322) refactor: Livechat Header -> ts (#30255) chore: Deprecate un-used meteor method for omnichannel analytics (#30421) feat: add supported versions + minimum clients versions to the info endpoint (#30178) feat: Auto-enable autotranslate (#30370) chore: Prevent call license and registration status endpoints when not enough permission (#30336) ci: Security/GitHub jira integration (#29776) feat: License V3 (#30287) chore: move Omnichannel toolbox section from sidebar room list (#30502) ...
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
package/jwtwithsignandveriyfunctions to create a JWT given a JS object.ee/package/licenseIssue(s)
https://rocketchat.atlassian.net/browse/NBJ-292
Steps to test or reproduce
Further comments