Skip to content

chore: adjust callbacks return type #30547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Oct 2, 2023
Merged

chore: adjust callbacks return type #30547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49a1999
adjust callback return type
ggazzo Oct 2, 2023
6a19b48
..
ggazzo Oct 2, 2023
cd8d70d
Merge branch 'develop' into chore/callcacks-async
kodiakhq[bot] Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/meteor/app/cloud/server/functions/getWorkspaceLicense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export async function getWorkspaceLicense(): Promise<{ updated: boolean; license
const fromCurrentLicense = async () => {
const license = currentLicense?.value as string | undefined;
if (license) {
callbacks.run('workspaceLicenseChanged', license);
await callbacks.run('workspaceLicenseChanged', license);
}

return { updated: false, license: license ?? '' };
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/lib/callbacks/callbacksBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export class Callbacks<
this.setCallbacks(hook, hooks);
}

run<Hook extends keyof TEventLikeCallbackSignatures>(hook: Hook, ...args: Parameters<TEventLikeCallbackSignatures[Hook]>): void;
run<Hook extends keyof TEventLikeCallbackSignatures>(hook: Hook, ...args: Parameters<TEventLikeCallbackSignatures[Hook]>): Promise<void>;

run<Hook extends keyof TChainedCallbackSignatures>(
hook: Hook,
Expand Down