Skip to content

Conversation

@tapiarafael
Copy link
Contributor

@tapiarafael tapiarafael commented Sep 27, 2023

Proposed changes (including videos or screenshots)

It is impossible to use the total number of license seats. The user is prevented from creating a new user when the seat counter is on the last available seat.
Setting the default value of the counter in the validation to zero instead of one, the user will be able to use the total license seat capacity.

Issue(s)

Steps to test or reproduce

In a workspace with an enterprise license:

  1. Create users until you have only one seat left;
  2. Try to create a new user to reach the maximum seat capacity;
  3. An error-license-user-limit-reached error will be shown;

Further comments

SUP-364

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

⚠️ No Changeset found

Latest commit: 7dd3fb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tapiarafael tapiarafael changed the title fix: seatsCap limit calculation fix: seatsCap wrong limit calculation Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #30508 (7dd3fb8) into develop (2872428) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30508      +/-   ##
===========================================
- Coverage    50.23%   50.19%   -0.04%     
===========================================
  Files          780      774       -6     
  Lines        14475    14454      -21     
  Branches      2616     2612       -4     
===========================================
- Hits          7271     7255      -16     
+ Misses        6809     6791      -18     
- Partials       395      408      +13     
Flag Coverage Δ
e2e 48.55% <ø> (-0.04%) ⬇️
unit 60.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael marked this pull request as ready for review September 27, 2023 15:43
@casalsgh casalsgh requested a review from a team September 28, 2023 14:49
@tapiarafael
Copy link
Contributor Author

Fixed by #30287

@tassoevan tassoevan deleted the fix/seat-cap-validation branch August 1, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants