[FIX] Sidebar context menu in searchList #23830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice fix! |
Contributor
Author
|
Thank you @ankar84 😄 |
|
|
dougfabris
requested changes
Apr 11, 2022
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
@Aman-Maheshwari Nice fix, thanks for your help. In touch with our product team, we decided we should keep closing the spotlight after selecting a room. Also there's some conflicts, could you check it?
dougfabris
approved these changes
Nov 18, 2022
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Nov 21, 2022
…age-ignore-reactivity * 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits) Chore: removing useEndpointData from license api (#26634) Chore: Create unique index for `E2EKey` field (#27301) [FIX] LDAP "Sync Roles" option doesn't work for custom roles (#26842) Chore: UserAvatar wrapper missing key in RoomForeword (#27300) Chore: Add deprecation warning to settings (#27295) Chore: Refactor LeaveTeam to Typescript (#27197) [FIX] Sidebar context menu in searchList (#23830) [NEW] Federation events coverage expansion (#27119) [FIX] Message Parser version upgrade (#27284) [FIX] Replace regex not compatible with safari (#27294) [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003) [FIX] Set default value "false" for global search. (#25568) Regression: Custom fields form not showing in user profile nor admin (#27244) [FIX] Sort RecordList items in REVERSE chronological order, not FORWARD (#27201) Chore: Remove unused css (#27289) Chore: also send thread to channel translations (#27242) [FIX] Marketplace app details page back-button behavior (#27062) Chore: Add tests for omni-jobs & add more context in system messages for jobs (#27048) Chore: Fix missing license for forks (#27258) i18n: Language update from LingoHub 🤖 on 2022-11-14Z (#27255) ...
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Douglas Fabris <[email protected]>
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Douglas Fabris <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Removed onClose function from the Box Component inside
searchList.jsas this component wraps the complete list which is rendered and when clicked on the any rendered row inside the component it closes the searchList preventing the context menu to be displayed.Also added
usePreventDefaulthook.Before
before_sidebar_contextmenu.mp4
After
after_sidebar_contextmenu.mp4
Issue(s)
Closes #22146
Steps to test or reproduce
Mentioned in the issue
Further comments
This PR solves this issue but In this PR
User can close the searchList only by clicking out somewhere which is handled via
useOutsideClickhook or by clicking on the cross icon in the search box. Also this gives user a chance to handle multiple search results inside searchList unlike everytime clicking the search icon on sidebar and perform action to a individual searched room or a user.Before this PR selecting a room or a user also closed the searchList but this action also prevented the context menu to get open as the searchList was closed immediately after clicking.