Skip to content

[FIX] Sidebar context menu in searchList #23830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 7 commits into from
Nov 18, 2022
Merged

[FIX] Sidebar context menu in searchList #23830

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c5a7b5
fix-sidebar-context-menu-in-search
Aman-Maheshwari Nov 30, 2021
820e654
Merge branch 'develop' into sidebar-context-menu-search
Aman-Maheshwari Dec 29, 2021
2c6862f
Merge branch 'develop' into sidebar-context-menu-search
Aman-Maheshwari Feb 12, 2022
aef57e8
Merge branch 'develop' into sidebar-context-menu-search
dougfabris Apr 6, 2022
b94b7a7
Merge branch 'develop' into sidebar-context-menu-search
dougfabris Nov 18, 2022
90fff2f
chore: click fn
dougfabris Nov 18, 2022
fc8d4a6
Merge branch 'develop' into sidebar-context-menu-search
kodiakhq[bot] Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/sidebar/search/SearchList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { useUserPreference, useUserSubscriptions } from '../../contexts/UserCont
import { AsyncStatePhase } from '../../hooks/useAsyncState';
import { useMethodData } from '../../hooks/useMethodData';
import { useAvatarTemplate } from '../hooks/useAvatarTemplate';
import { usePreventDefault } from '../hooks/usePreventDefault';
import { useTemplateByViewMode } from '../hooks/useTemplateByViewMode';
import Row from './Row';
import ScrollerWithCustomProps from './ScrollerWithCustomProps';
Expand Down Expand Up @@ -200,6 +201,8 @@ const SearchList = forwardRef(function SearchList({ onClose }, ref) {
}
});

usePreventDefault(boxRef);

useEffect(() => {
resetCursor();
});
Expand Down Expand Up @@ -282,7 +285,6 @@ const SearchList = forwardRef(function SearchList({ onClose }, ref) {
h='full'
w='full'
data-qa='sidebar-search-result'
onClick={onClose}
aria-busy={status !== AsyncStatePhase.RESOLVED}
>
<Virtuoso
Expand Down