Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Nov 18, 2022

Proposed changes (including videos or screenshots)

image

List of settings:

  • Show edited status
  • Allow Message snippeting
  • Show formating Tips
  • Disable Embeded for Users
  • Issue tracker links
  • Message attachments > Group Attachment Buttons
  • Markdown > All settings inside Group
  • Autolinker > All settings inside Group

Edited Message for old federation.

Issue(s)

TC-272

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner November 18, 2022 12:44
yash-rajpal
yash-rajpal previously approved these changes Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #27295 (f5a46b4) into develop (e3af648) will increase coverage by 0.79%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27295      +/-   ##
===========================================
+ Coverage    40.55%   41.35%   +0.79%     
===========================================
  Files          840      812      -28     
  Lines        18329    17832     -497     
  Branches      2052     1988      -64     
===========================================
- Hits          7434     7374      -60     
+ Misses       10609    10174     -435     
+ Partials       286      284       -2     
Flag Coverage Δ
e2e 41.35% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh added this to the 5.4.0 milestone Nov 18, 2022
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 18, 2022
…ecateSettings

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Federation events coverage expansion (#27119)
  [FIX] Message Parser version upgrade (#27284)
  [FIX] Replace regex not compatible with safari (#27294)
  [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003)
@kodiakhq kodiakhq bot merged commit f654860 into develop Nov 19, 2022
@kodiakhq kodiakhq bot deleted the deprecateSettings branch November 19, 2022 00:11
gabriellsh added a commit that referenced this pull request Nov 21, 2022
…age-ignore-reactivity

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  Chore: removing useEndpointData from license api (#26634)
  Chore: Create unique index for `E2EKey` field (#27301)
  [FIX] LDAP "Sync Roles" option doesn't work for custom roles (#26842)
  Chore: UserAvatar wrapper missing key in RoomForeword (#27300)
  Chore: Add deprecation warning to settings (#27295)
  Chore: Refactor LeaveTeam to Typescript (#27197)
  [FIX] Sidebar context menu in searchList (#23830)
  [NEW] Federation events coverage expansion (#27119)
  [FIX] Message Parser version upgrade (#27284)
  [FIX] Replace regex not compatible with safari (#27294)
  [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003)
  [FIX] Set default value "false" for global search. (#25568)
  Regression: Custom fields form not showing in user profile nor admin (#27244)
  [FIX] Sort RecordList items in REVERSE chronological order, not FORWARD (#27201)
  Chore: Remove unused css (#27289)
  Chore: also send thread to channel translations (#27242)
  [FIX] Marketplace app details page back-button behavior (#27062)
  Chore: Add tests for omni-jobs & add more context in system messages for jobs (#27048)
  Chore: Fix missing license for forks (#27258)
  i18n: Language update from LingoHub 🤖 on 2022-11-14Z (#27255)
  ...
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants