Skip to content

[FIX] Agent information panel not rendering #19965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renatobecker merged 4 commits into from
Dec 30, 2020
Merged

[FIX] Agent information panel not rendering #19965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb73b7f
Changing default import to named import and only showing MaxNumber fi…
rafaelblink Dec 24, 2020
aac7ba6
Agents (edit and info) enhancements with translation missing and alig…
rafaelblink Dec 28, 2020
28fa547
Merge branch 'develop' into omnichannel/fix-agent-information
renatobecker Dec 29, 2020
06f59a2
Merge branch 'develop' into omnichannel/fix-agent-information
renatobecker Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/views/omnichannel/agents/AgentEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ export function AgentEdit({ data, userDepartments, availableDepartments, uid, re
useMaxChatsPerAgent = () => {},
} = eeForms;

console.log(eeForms, useMaxChatsPerAgent());

const { values, handlers, hasUnsavedChanges, commit } = useForm({ departments: initialDepartmentValue, status: statusLivechat, maxChats: 0 });
const {
reset: resetMaxChats,
Expand Down Expand Up @@ -109,7 +107,9 @@ export function AgentEdit({ data, userDepartments, availableDepartments, uid, re
});

return <VerticalBar.ScrollableContent is='form' { ...props }>
<UserInfo.Avatar margin='auto' size={'x332'} title={username} username={username}/>
<Box alignSelf='center'>
<UserInfo.Avatar margin='auto' size={'x332'} title={username} username={username}/>
</Box>
<Field>
<Field.Label>{t('Name')}</Field.Label>
<Field.Row>
Expand Down
8 changes: 6 additions & 2 deletions client/views/omnichannel/agents/AgentInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,18 @@ export const AgentInfo = React.memo(function AgentInfo({

return <VerticalBar.ScrollableContent p='x24' {...props}>

<UserInfo.Avatar size={'x332'} username={username}/>
<Box alignSelf='center'>
<UserInfo.Avatar size={'x332'} username={username}/>
</Box>

<ButtonGroup mi='neg-x4' flexShrink={0} flexWrap='nowrap' withTruncatedText justifyContent='center' flexShrink={0}>
{children}
</ButtonGroup>

<Margins block='x4'>
<UserInfo.Username name={username} status={<UserStatus status={userStatus} />} />
<Box mb='x2'>
<UserInfo.Username name={username} status={<UserStatus status={userStatus} />} />
</Box>

{statusLivechat && <>
<UserInfo.Label>{t('Livechat_status')}</UserInfo.Label>
Expand Down
5 changes: 2 additions & 3 deletions ee/client/omnichannel/additionalForms/MaxChatsPerAgentDisplay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import React from 'react';

import { useTranslation } from '../../../../client/contexts/TranslationContext';
import UserInfo from '../../../../client/views/room/contextualBar/UserInfo';
import { UserInfo } from '../../../../client/views/room/contextualBar/UserInfo';

const MaxChatsPerAgentDisplay = ({ data: { livechat: { maxNumberSimultaneousChat = '' } = {} } = {} }) => {
const t = useTranslation();

return <>
return maxNumberSimultaneousChat && <>
<UserInfo.Label>{t('Max_number_of_chats_per_agent')}</UserInfo.Label>
<UserInfo.Info>{maxNumberSimultaneousChat}</UserInfo.Info>
</>;
Expand Down
1 change: 1 addition & 0 deletions packages/rocketchat-i18n/i18n/pt-BR.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,6 +1219,7 @@
"Edit_Tag": "Editar Tag",
"Edit_Trigger": "Editar Gatilho",
"Edit_Unit": "Editar Unidade",
"Edit_User": "Editar usuário",
"edit-message": "Editar mensagem",
"edit-message_description": "Permissão para editar uma mensagem dentro de uma sala",
"edit-other-user-active-status": "Editar outro status ativo do usuário",
Expand Down