Improve: Rewrite admin sidebar in React #17801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rewrite_admin_sidebar * 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits) Readme: Update Raspberry Pi 2 to Pi 4 (#17031) [NEW] Accept variable `#{userdn}` on LDAP group filter (#16273) [FIX] Spotify embed link opens in same tab (#13637) [FIX] Markdown links not accepting URLs with parentheses (#13605) [NEW][API] Endpoint `settings.addCustomOAuth` to create Custom OAuth services (#14912) [IMPROVE] Make the implementation of custom code easier by having placeholders for a custom folder (#15106) [NEW] Skip Export Operations that haven't been updated in over a day (#16135) [NEW] Highlight matching words in message search results (#16166) [FIX] Set `x-content-type-options: nosniff` header (#16232) [FIX] Disabling `Json Web Tokens protection to file uploads` disables the File Upload protection entirely (#16262) Fixes some italian word (#14008) Bump version to 3.4.0-develop Bump version to 3.3.0 Bump version to 3.3.0-rc.4 Bump version to 3.3.0-rc.3 Bump version to 3.3.0-rc.2 Bump version to 3.3.0-rc.1 Bump version to 3.3.0-rc.0 [FIX] Slack importer Link handling (#17595) Bump version to 3.2.2 ...
tassoevan
reviewed
Jun 1, 2020
tassoevan
reviewed
Jun 1, 2020
tassoevan
reviewed
Jun 1, 2020
…rewrite_admin_sidebar * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] When the message is too long declining to send as an attachment does not restore the content into the composer (#16332) [IMPROVE][Federation] Add support for _tcp and protocol DNS entries (#17818) Fix the update check not working (#17809) Add Apps-Engine to Engine Versions on History (#17810) [FIX] Link preview containing HTML encoded chars (#16512) [FIX] Email link "go to message" being incorrectly escaped (#17803) [FIX] Error when re-installing an App (#17789) Update Apps-Engine version (#17804) Fix invalid develop payload to release service (#17799)
ggazzo
reviewed
Jun 9, 2020
client/admin/sidebar/AdminSidebar.js
Outdated
| const params = useMemo(() => ({ group: pathGroup }), [pathGroup]); | ||
| const path = useRoutePath(href, params); | ||
| const isActive = path === currentPath || false; | ||
| return useMemo(() => <Box |
Contributor
There was a problem hiding this comment.
@ggazzo React.memo() returns a new component, which should be declared outside this component scope.
Member
There was a problem hiding this comment.
sure I know , but why not wrap the component as a memoized component instead if this approach?
tassoevan
changed the title
ggazzo
changed the title
…ket.Chat into new/rewrite_admin_sidebar * 'new/rewrite_admin_sidebar' of github.com:RocketChat/Rocket.Chat: Always initialize CIRCLE_BRANCH env var on CI (#17874)
|
This pull request introduces 2 alerts when merging d94ade6 into 70498a4 - view on LGTM.com new alerts:
|
gabriellsh
added a commit
that referenced
this pull request
Jun 13, 2020
…into new/apps_rewrite_local * 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat: correct outdated dev start info [IMPROVE] Rewrite Federation Dashboard (#17900) [FIX] Duplicated placeholderaceholder (#17898) Wrap components with React.memo (#17899) Fix Review [FIX] Some Login Buttons disappear after refreshing OAuth Services (#17808) Change some components' location (#17893) [IMPROVE] Rewrite admin sidebar in React (#17801) Always initialize CIRCLE_BRANCH env var on CI (#17874)
ggazzo
added a commit
that referenced
this pull request
Jun 17, 2020
…o threads-alpha * 'threads-alpha' of github.com:RocketChat/Rocket.Chat: (23 commits) [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839) [FIX] Undesirable message updates after user saving profile (#17930) Remove unused accounts-js integration (#17921) [IMPROVE] Don't send emails to online users and remove delay when away/idle (#17907) [IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate variables (#17669) correct outdated dev start info [IMPROVE] Rewrite Federation Dashboard (#17900) [FIX] Duplicated placeholderaceholder (#17898) Wrap components with React.memo (#17899) [FIX] Some Login Buttons disappear after refreshing OAuth Services (#17808) Change some components' location (#17893) [IMPROVE] Rewrite admin sidebar in React (#17801) Always initialize CIRCLE_BRANCH env var on CI (#17874) [NEW] Blocked Media Types setting (#17617) [FIX] Reorder hljs (#17854) [FIX] SAML LogoutRequest sending wrong NameID (#17860) [FIX] Apps room events losing data (#17827) [FIX] Importers progress sending too much update events to clients (#17857) [FIX] Omnichannel message link is broken in email notifications (#17843) [FIX] Logic for room type was inverted in edit panel (#17851) (#17853) ...
Merged
Contributor
|
Looks like this rewrite does not take into account, that Rocket.Chat might run with a path prefix like eg. /rocketchat, then you can NOT use the administration anymore see #18105 Can someone please have a look and fix that. Ralf |
rodrigok
changed the title
omarchehab98
added a commit
to omarchehab98/Rocket.Chat
that referenced
this pull request
Jul 3, 2020
…tChat#18105) Closes: RocketChat#18105 Related: RocketChat#17801 Steps to reproduce: 1. Start server with ROOT_URL http://localhost:3000/rc 2. Navigate to /rc/admin Before: 3. Observe admin closes After: 3. Observe admin remains open Additional test cases: 1. Start server with ROOT_URL http://localhost:3000 2. Navigate to /rc/admin 3. Observer admin remains open
12 tasks
omarchehab98
added a commit
to omarchehab98/Rocket.Chat
that referenced
this pull request
Jul 3, 2020
…tChat#18105) Closes: RocketChat#18105 Related: RocketChat#17801 Steps to reproduce: 1. Start server with ROOT_URL http://localhost:3000/rc 2. Navigate to /rc/admin Before: 3. Observe admin closes After: 3. Observe admin remains open Additional test cases: 1. Start server with ROOT_URL http://localhost:3000 2. Navigate to /rc/admin 3. Observer admin remains open
omarchehab98
added a commit
to omarchehab98/Rocket.Chat
that referenced
this pull request
Jul 3, 2020
…tChat#18105) Closes: RocketChat#18105 Related: RocketChat#17801 Steps to reproduce: 1. Start server with ROOT_URL http://localhost:3000/rc 2. Navigate to /rc/admin Before: 3. Observe admin closes After: 3. Observe admin remains open Additional test cases: 1. Start server with ROOT_URL http://localhost:3000 2. Navigate to /admin 3. Observer admin remains open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.