[IMPROVE] Don't send emails to online users and remove delay when away/idle #17907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
approved these changes
Jun 15, 2020
ggazzo
added a commit
that referenced
this pull request
Jun 17, 2020
…o threads-alpha * 'threads-alpha' of github.com:RocketChat/Rocket.Chat: (23 commits) [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839) [FIX] Undesirable message updates after user saving profile (#17930) Remove unused accounts-js integration (#17921) [IMPROVE] Don't send emails to online users and remove delay when away/idle (#17907) [IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate variables (#17669) correct outdated dev start info [IMPROVE] Rewrite Federation Dashboard (#17900) [FIX] Duplicated placeholderaceholder (#17898) Wrap components with React.memo (#17899) [FIX] Some Login Buttons disappear after refreshing OAuth Services (#17808) Change some components' location (#17893) [IMPROVE] Rewrite admin sidebar in React (#17801) Always initialize CIRCLE_BRANCH env var on CI (#17874) [NEW] Blocked Media Types setting (#17617) [FIX] Reorder hljs (#17854) [FIX] SAML LogoutRequest sending wrong NameID (#17860) [FIX] Apps room events losing data (#17827) [FIX] Importers progress sending too much update events to clients (#17857) [FIX] Omnichannel message link is broken in email notifications (#17843) [FIX] Logic for room type was inverted in edit panel (#17851) (#17853) ...
Merged
|
This was not fixed, I'm still getting emails. Looks like connection status isn't being used as a parameter? sendNotificationsOnMessage.js (148) |
Member
Author
|
this improvement was released today on 3.4.0 release.. did you update already? |
12 tasks
|
Yes I'm already on 3.4.0 and still have the issue. Isn't the parameter missing, or am I missing something? |
This was referenced Oct 1, 2020
Open
|
Hello, we're running 3.13.2 and emails are still sent to 'away' users. We dig this further and here's what we found:
Can someone please check the code and fix this for good? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This reverts some undesired changes introduced by #17357, so with this changes:
Issue(s)
Closes #17492
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments